Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2891613002: Add no-compile test for UmaHistogramEnumeration (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add no-compile test for UmaHistogramEnumeration BUG=661401 Review-Url: https://codereview.chromium.org/2891613002 Cr-Commit-Position: refs/heads/master@{#472340} Committed: https://chromium.googlesource.com/chromium/src/+/10e7f397ba671b138eab9796bbe3e44158ee3d1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M base/metrics/histogram_unittest.nc View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-16 23:20:17 UTC) #2
dcheng
lgtm
3 years, 7 months ago (2017-05-17 04:09:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891613002/1
3 years, 7 months ago (2017-05-17 05:11:52 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:29:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10e7f397ba671b138eab9796bbe3...

Powered by Google App Engine
This is Rietveld 408576698