Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2891583003: Revert of Disable two (unrelated) flaky tests on win (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable two (unrelated) flaky tests on win (patchset #1 id:1 of https://codereview.chromium.org/2893663002/ ) Reason for revert: At least one of those was clearly a registry issue most likely caused by https://crbug.com/721245 which was just fixed. Trying to re-enable. Original issue's description: > Disable two (unrelated) flaky tests on win > > BUG=723291, 723548 > TBR=sergeyu,joaodasilva > NOTRY=true > > Review-Url: https://codereview.chromium.org/2893663002 > Cr-Commit-Position: refs/heads/master@{#472484} > Committed: https://chromium.googlesource.com/chromium/src/+/bcfce6f4c4baed202a648f1bc2958a6898a99f0d TBR=sergeyu@chromium.org,joaodasilva@chromium.org,dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=723291, 723548 Review-Url: https://codereview.chromium.org/2891583003 Cr-Commit-Position: refs/heads/master@{#472569} Committed: https://chromium.googlesource.com/chromium/src/+/8a11e9c756ea45362903573202183fba2b4b1fbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
gab
Created Revert of Disable two (unrelated) flaky tests on win
3 years, 7 months ago (2017-05-17 21:05:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891583003/1
3 years, 7 months ago (2017-05-17 21:07:23 UTC) #3
dmazzoni
lgtm
3 years, 7 months ago (2017-05-17 21:09:42 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 21:10:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a11e9c756ea4536290357320218...

Powered by Google App Engine
This is Rietveld 408576698