Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2891503003: color: Initialize renderer color space in testing (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Initialize renderer color space in testing Initialize RendererSettings::enable_color_correct_rendering in RenderWidgetCompositor (previously we were just doing rasterization). Initialize cc:Display's output color spaces to sRGB, instead of leaving it uninitialized. BUG=713891 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2891503003 Cr-Commit-Position: refs/heads/master@{#472948} Committed: https://chromium.googlesource.com/chromium/src/+/37ed23df46e520bfea1abbab1ffdf4d5d40c0df4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M cc/surfaces/display.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ccameron
ptal -- touch-ups!
3 years, 7 months ago (2017-05-16 20:25:03 UTC) #3
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-16 20:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891503003/1
3 years, 7 months ago (2017-05-16 20:44:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/446289)
3 years, 7 months ago (2017-05-17 01:38:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891503003/1
3 years, 7 months ago (2017-05-18 19:48:43 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:08:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37ed23df46e520bfea1abbab1ffd...

Powered by Google App Engine
This is Rietveld 408576698