Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 2891493004: Tooltip for home page menu buttons (Closed)
Patch Set: refine descriptions of commit and tooltip strings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
index 7d380ddfdf5375fabb1534e05818cf880f1a22dd..bba9583e3abbd53a677d72bc245ea58885749bc3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
@@ -58,6 +58,7 @@ import org.chromium.chrome.browser.omnibox.LocationBar;
import org.chromium.chrome.browser.omnibox.LocationBarPhone;
import org.chromium.chrome.browser.partnercustomizations.HomepageManager;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.util.AccessibilityUtil;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.util.MathUtils;
@@ -400,6 +401,7 @@ public class ToolbarPhone extends ToolbarLayout
}
});
mNewTabButton.setOnClickListener(this);
+ mNewTabButton.setOnLongClickListener(this);
}
@Override
@@ -502,10 +504,13 @@ public class ToolbarPhone extends ToolbarLayout
CharSequence description = null;
if (v == mToggleTabStackButton) {
description = getResources().getString(R.string.open_tabs);
+ } else if (v == mNewTabButton) {
+ description = getResources().getString(
+ isIncognito() ? R.string.button_new_incognito_tab : R.string.button_new_tab);
} else {
return false;
}
- return showAccessibilityToast(v, description);
+ return AccessibilityUtil.showAccessibilityToast(getContext(), v, description);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698