Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 2891493004: Tooltip for home page menu buttons (Closed)
Patch Set: refine descriptions of commit and tooltip strings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
index cd1597348f20859004656d7a1f2fb2d53f93ff63..9b77e47e66277000502d67210a10e856ed343928 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
@@ -15,7 +15,6 @@ import android.graphics.Rect;
import android.graphics.drawable.Drawable;
import android.os.SystemClock;
import android.util.AttributeSet;
-import android.view.Gravity;
import android.view.View;
import android.view.ViewGroup;
import android.widget.FrameLayout;
@@ -39,7 +38,6 @@ import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.chrome.browser.widget.ToolbarProgressBar;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
import org.chromium.ui.UiUtils;
-import org.chromium.ui.widget.Toast;
import javax.annotation.Nullable;
@@ -280,29 +278,6 @@ public abstract class ToolbarLayout extends FrameLayout implements Toolbar {
}
/**
- * Shows the content description toast for items on the toolbar.
- * @param view The view to anchor the toast.
- * @param description The string shown in the toast.
- * @return Whether a toast has been shown successfully.
- */
- protected boolean showAccessibilityToast(View view, CharSequence description) {
- if (description == null) return false;
-
- final int screenWidth = getResources().getDisplayMetrics().widthPixels;
- final int[] screenPos = new int[2];
- view.getLocationOnScreen(screenPos);
- final int width = view.getWidth();
-
- Toast toast = Toast.makeText(getContext(), description, Toast.LENGTH_SHORT);
- toast.setGravity(
- Gravity.TOP | Gravity.END,
- screenWidth - screenPos[0] - width / 2,
- screenPos[1] + getHeight() / 2);
- toast.show();
- return true;
- }
-
- /**
* @return The provider for toolbar related data.
*/
protected ToolbarDataProvider getToolbarDataProvider() {

Powered by Google App Engine
This is Rietveld 408576698