Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2891493004: Tooltip for home page menu buttons (Closed)
Patch Set: refine descriptions of commit and tooltip strings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
index 4631ee96f4f97274facaf241268a7c604d502b86..402297133b555ae282b8e59b328c562d4b73c120 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
@@ -35,9 +35,11 @@ import android.widget.PopupWindow.OnDismissListener;
import org.chromium.base.AnimationFrameTimeHistogram;
import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.base.ContextUtils;
import org.chromium.base.SysUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
+import org.chromium.chrome.browser.util.AccessibilityUtil;
import org.chromium.chrome.browser.widget.PulseDrawable;
import java.util.ArrayList;
@@ -376,6 +378,33 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
}
}
+ /**
+ * Handles long clicks on image buttons on the AppMenu popup.
+ * @param menuItem The menu item in the popup that was long clicked.
+ * @param view The anchor view of the menu item.
+ */
+ boolean onItemLongClick(MenuItem menuItem, View view) {
+ if (!menuItem.isEnabled()) return false;
+
+ String description = null;
+ Context context = ContextUtils.getApplicationContext();
+ Resources resources = context.getResources();
+ final int itemId = menuItem.getItemId();
+
+ if (itemId == R.id.forward_menu_id) {
+ description = resources.getString(R.string.menu_forward);
+ } else if (itemId == R.id.bookmark_this_page_id) {
+ description = resources.getString(R.string.menu_bookmark);
+ } else if (itemId == R.id.offline_page_id) {
+ description = resources.getString(R.string.menu_download);
+ } else if (itemId == R.id.info_menu_id) {
+ description = resources.getString(R.string.menu_page_info);
+ } else if (itemId == R.id.reload_menu_id) {
+ description = resources.getString(R.string.menu_refresh);
+ }
+ return AccessibilityUtil.showAccessibilityToast(context, view, description);
+ }
+
@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
onItemClick(mAdapter.getItem(position));

Powered by Google App Engine
This is Rietveld 408576698