Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2891453006:
Check DeviceSettingsService is intialized before using. (Closed)
|
Created:
3 years, 7 months ago by xiaoyinh(OOO Sep 11-29) Modified:
3 years, 7 months ago CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionCheck DeviceSettingsService is intialized before using.
BUG=723768
Review-Url: https://codereview.chromium.org/2891453006
Cr-Commit-Position: refs/heads/master@{#472850}
Committed: https://chromium.googlesource.com/chromium/src/+/80eb240f54aa29f667898de5fdd34984a08903d2
Patch Set 1 #
Total comments: 2
Patch Set 2 : update comment #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Check DeviceSettingsService is intialized before using. BUG= ========== to ========== Check DeviceSettingsService is intialized before using. BUG=723768 ==========
xiaoyinh@chromium.org changed reviewers: + xiyuan@chromium.org
xiyuan@, could you take a look? Thanks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xiyuan@chromium.org changed reviewers: + emaxx@chromium.org
lgtm +emaxx for owner review. https://codereview.chromium.org/2891453006/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc (right): https://codereview.chromium.org/2891453006/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc:91: // SystemSaltGetter or DBusThreadManager may be uninitialized on unit tests. Update this document too.
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
https://codereview.chromium.org/2891453006/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc (right): https://codereview.chromium.org/2891453006/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc:91: // SystemSaltGetter or DBusThreadManager may be uninitialized on unit tests. On 2017/05/17 19:56:36, xiyuan wrote: > Update this document too. Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
lgtm
The CQ bit was checked by xiaoyinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org Link to the patchset: https://codereview.chromium.org/2891453006/#ps20001 (title: "update comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495126662770670,
"parent_rev": "c72f3c4c940c6ada4e0447bfd2dd5dfdf532fdf1", "commit_rev":
"80eb240f54aa29f667898de5fdd34984a08903d2"}
Message was sent while issue was closed.
Description was changed from ========== Check DeviceSettingsService is intialized before using. BUG=723768 ========== to ========== Check DeviceSettingsService is intialized before using. BUG=723768 Review-Url: https://codereview.chromium.org/2891453006 Cr-Commit-Position: refs/heads/master@{#472850} Committed: https://chromium.googlesource.com/chromium/src/+/80eb240f54aa29f667898de5fdd3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/80eb240f54aa29f667898de5fdd3... |
