Introduce networkingPrivate.getCertificateLists

Introduce networkingPrivate.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891453002
Cr-Commit-Position: refs/heads/master@{#474836}
Committed: https://chromium.googlesource.com/chromium/src/+/bbb23b76fd2d8e7f864deff6e70c10bf4fddeb87

[stevenjb, 2017-05-16 16:54:58]

Description was changed from

==========
Introduce networkingPrivete.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
==========

to

==========
Introduce networkingPrivete.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-16 19:51:00]

stevenjb@chromium.org changed reviewers:
+ tbarzic@chromium.org

[stevenjb, 2017-05-17 17:51:28]

Description was changed from

==========
Introduce networkingPrivete.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Introduce networkingPrivate.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tbarzic, 2017-05-17 22:35:57]

https://codereview.chromium.org/2891453002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
(right):

https://codereview.chromium.org/2891453002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:15:
#include "base/json/json_string_value_serializer.h"
not needed?

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
(right):

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:803:
var listener = callbackPass(function() {
chrome.test.listenOnce should do something similar

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:809:
chrome.networkingPrivate.getCertificateLists(function() {console.info('GOT
CERTS');});
remove log

(and add callbackPass so the test fails appropriately if getCertificateLists
fails)

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
File chromeos/network/network_certificate_handler.cc (right):

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
chromeos/network/network_certificate_handler.cc:43:
CertLoader::GetPkcs11IdAndSlotForCert(cert, &slot_id);
is this fine to be called from the UI thread?

https://codereview.chromium.org/2891453002/diff/20001/components/onc/docs/onc...
File components/onc/docs/onc_spec.md (right):

https://codereview.chromium.org/2891453002/diff/20001/components/onc/docs/onc...
components/onc/docs/onc_spec.md:1055: only valid when describing a local
configuraiton.
typo: configuration

https://codereview.chromium.org/2891453002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2891453002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:1066:
std::unique_ptr<base::DictionaryValue> certificate_lists(
I guess we're OK with exposing this as part of the public networking.onc API?

[stevenjb, 2017-05-18 16:30:56]

stevenjb@chromium.org changed reviewers:
+ isherman@chromium.org, rdevlin.cronin@chromium.org

[stevenjb, 2017-05-18 16:30:57]

+rdevlin.cronin@ for networking_private.idl change
+isherman@ for histograms changes

https://codereview.chromium.org/2891453002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
(right):

https://codereview.chromium.org/2891453002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:15:
#include "base/json/json_string_value_serializer.h"
On 2017/05/17 22:35:57, tbarzic wrote:
> not needed?

oops. done.

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
(right):

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:803:
var listener = callbackPass(function() {
On 2017/05/17 22:35:57, tbarzic wrote:
> chrome.test.listenOnce should do something similar

Done.

https://codereview.chromium.org/2891453002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:809:
chrome.networkingPrivate.getCertificateLists(function() {console.info('GOT
CERTS');});
On 2017/05/17 22:35:57, tbarzic wrote:
> remove log
> 
> (and add callbackPass so the test fails appropriately if getCertificateLists
> fails)

Done.

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
File chromeos/network/network_certificate_handler.cc (right):

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
chromeos/network/network_certificate_handler.cc:43:
CertLoader::GetPkcs11IdAndSlotForCert(cert, &slot_id);
On 2017/05/17 22:35:57, tbarzic wrote:
> is this fine to be called from the UI thread?

It should be fine (we already do so in WifiConfigView and elsewhere in the
code). This just calls a PK11_ function which just extracts data from the
certificate which is just a pointer to a memory blob. It does some hex encoding
also, but no file IO or TPM operations, and the certificate blobs are not very
large.

https://codereview.chromium.org/2891453002/diff/20001/components/onc/docs/onc...
File components/onc/docs/onc_spec.md (right):

https://codereview.chromium.org/2891453002/diff/20001/components/onc/docs/onc...
components/onc/docs/onc_spec.md:1055: only valid when describing a local
configuraiton.
On 2017/05/17 22:35:57, tbarzic wrote:
> typo: configuration

Done.

https://codereview.chromium.org/2891453002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2891453002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:1066:
std::unique_ptr<base::DictionaryValue> certificate_lists(
On 2017/05/17 22:35:57, tbarzic wrote:
> I guess we're OK with exposing this as part of the public networking.onc API?

semi-public :P It doesn't add any more vulnerability than, say, providing access
to the proxy configuration.

[Ilya Sherman, 2017-05-18 17:23:27]

https://codereview.chromium.org/2891453002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_event_histogram_value.h (right):

https://codereview.chromium.org/2891453002/diff/40001/extensions/browser/exte...
extensions/browser/extension_event_histogram_value.h:431: // python
tools/metrics/histograms/update_extension_histograms.py
^^^

https://codereview.chromium.org/2891453002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/2891453002/diff/40001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1239: // python
tools/metrics/histograms/update_extension_histograms.py
^^^

[Devlin, 2017-05-18 21:25:53]

If this is being added to the public API, it needs to go through security
review.  Has anyone from the security team looked at the proposal and signed
off?

[stevenjb, 2017-05-19 17:45:59]

So, because we made chrome.onc (which is just an alias to
chrome.networkingPrivate) available to kiosk apps, these apis are
considered public?

Did we go through a security review for that change?


On Thu, May 18, 2017 at 3:25 PM, <rdevlin.cronin@chromium.org> wrote:

> If this is being added to the public API, it needs to go through security
> review. Has anyone from the security team looked at the proposal and signed
> off?
>
> https://codereview.chromium.org/2891453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tbarzic, 2017-05-19 18:07:49]

yes, that went through security review.

I'd just check that the caller has "private" permission when you call the
function
(and enable it for onc API when it gets OKed by security):

if (!HasPrivateNetworkingAccess(extension(), source_context_type(),
                                source_url())) {
  return RespondNow(Error(kPrivateOnlyError));
}

[stevenjb, 2017-05-19 18:09:15]

tbarzic@ -Thanks!  Can you point me to the security review document for
networking.onc?



On Fri, May 19, 2017 at 12:07 PM, <tbarzic@chromium.org> wrote:

> yes, that went through security review.
>
> I'd just check that the caller has "private" permission when you call the
> function
> (and enable it for onc API when it gets OKed by security):
>
> if (!HasPrivateNetworkingAccess(extension(), source_context_type(),
> source_url())) {
> return RespondNow(Error(kPrivateOnlyError));
> }
>
> https://codereview.chromium.org/2891453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tbarzic, 2017-05-19 19:58:02]

I don't think there's a doc per se. but the gist was that we shouldn't not
expose functionality that could be used to intercept all network traffic (e.g.
changing proxy configuration).

[stevenjb, 2017-05-22 23:26:36]

PTAL

tbarzic@ - If there wasn't a security review document, is there an email thread
you can direct me to, or a security team member that is already familiar with
networking.onc that I can include here?

[tbarzic, 2017-05-22 23:40:51]

On 2017/05/22 23:26:36, stevenjb wrote:
> PTAL
> 
> tbarzic@ - If there wasn't a security review document, is there an email
thread
> you can direct me to, or a security team member that is already familiar with
> networking.onc that I can include here?

kerrnel@ was the one looking at the API

[stevenjb, 2017-05-22 23:46:13]

stevenjb@chromium.org changed reviewers:
+ kerrnel@chromium.org

[stevenjb, 2017-05-22 23:46:13]

+kerrnel@ - I'm adding a method to the networkingPrivate IDL which passes a list
of available certificates to the Settings UI. We decided not to make this
available to networking.onc (which is available to kiosk apps) since it is only
necessary for configuring 802.1x networks in the Settings UI. LMKWYT.

[Ilya Sherman, 2017-05-23 00:21:00]

enum changes lgtm

[tbarzic, 2017-05-23 18:01:58]

lgtm

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
File chromeos/network/network_certificate_handler.cc (right):

https://codereview.chromium.org/2891453002/diff/20001/chromeos/network/networ...
chromeos/network/network_certificate_handler.cc:43:
CertLoader::GetPkcs11IdAndSlotForCert(cert, &slot_id);
On 2017/05/18 16:30:57, stevenjb wrote:
> On 2017/05/17 22:35:57, tbarzic wrote:
> > is this fine to be called from the UI thread?
> 
> It should be fine (we already do so in WifiConfigView and elsewhere in the
> code). This just calls a PK11_ function which just extracts data from the
> certificate which is just a pointer to a memory blob. It does some hex
encoding
> also, but no file IO or TPM operations, and the certificate blobs are not very
> large.

Acknowledged.

https://codereview.chromium.org/2891453002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
(right):

https://codereview.chromium.org/2891453002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc:164:

private:

https://codereview.chromium.org/2891453002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
(right):

https://codereview.chromium.org/2891453002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:805: //
The test delegate will send a change event when we request the certs.
I'd go with something more explicit here, e.g.
chrome.test.sendMessage('listenerReady');
and have browser fire onCertificateListsChanged  when it received this message.

up to you, though

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/networ...
File chromeos/network/network_certificate_handler.cc (right):

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/networ...
chromeos/network/network_certificate_handler.cc:112: VLOG(2) << "Ignoring root
cert";
this VLOG should go to else part.

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translation_tables.cc (right):

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_translation_tables.cc:25: // This field are converted
during translation, see onc_translator_*.
s/are/is/

[Greg K, 2017-05-23 18:41:08]

On 2017/05/22 23:46:13, stevenjb wrote:
> +kerrnel@ - I'm adding a method to the networkingPrivate IDL which passes a
list
> of available certificates to the Settings UI. We decided not to make this
> available to networking.onc (which is available to kiosk apps) since it is
only
> necessary for configuring 802.1x networks in the Settings UI. LMKWYT.

So this is only exposed through the current private API?

[stevenjb, 2017-05-23 19:17:00]

On 2017/05/23 18:41:08, Greg K wrote:
> On 2017/05/22 23:46:13, stevenjb wrote:
> > +kerrnel@ - I'm adding a method to the networkingPrivate IDL which passes a
> list
> > of available certificates to the Settings UI. We decided not to make this
> > available to networking.onc (which is available to kiosk apps) since it is
> only
> > necessary for configuring 802.1x networks in the Settings UI. LMKWYT.
> 
> So this is only exposed through the current private API?

Correct. We do not expose it in the IDL and in networking_private_api.cc we test
against HasPrivateNetworkingAccess() like we do for other functions that are
disallowed in networking.onc.

[stevenjb, 2017-05-25 00:01:11]

Devlin - PTAL

Greg K - Do you have any other concerns? To clarify my previous comment, we do
not expose getCertificateLists() in the networking.onc IDL, and in
networking_private_api.cc we also test against HasPrivateNetworkingAccess() like
we do for other functions that are disallowed in networking.onc to ensure that
it can only be called from WebUI or whitelisted networkingPrivate extensions
(i.e. chromecast).

https://codereview.chromium.org/2891453002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
(right):

https://codereview.chromium.org/2891453002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc:164:

On 2017/05/23 18:01:58, tbarzic wrote:
> private:

Done.

https://codereview.chromium.org/2891453002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
(right):

https://codereview.chromium.org/2891453002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js:805: //
The test delegate will send a change event when we request the certs.
On 2017/05/23 18:01:58, tbarzic wrote:
> I'd go with something more explicit here, e.g.
> chrome.test.sendMessage('listenerReady');
> and have browser fire onCertificateListsChanged  when it received this
message.
> 
> up to you, though

Ah, I knew there had to be a better way. I think I have a mental block against
chrome.send and friends :) Done!

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/networ...
File chromeos/network/network_certificate_handler.cc (right):

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/networ...
chromeos/network/network_certificate_handler.cc:112: VLOG(2) << "Ignoring root
cert";
On 2017/05/23 18:01:58, tbarzic wrote:
> this VLOG should go to else part.

Oops, good catch. Done.

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translation_tables.cc (right):

https://codereview.chromium.org/2891453002/diff/60001/chromeos/network/onc/on...
chromeos/network/onc/onc_translation_tables.cc:25: // This field are converted
during translation, see onc_translator_*.
On 2017/05/23 18:01:58, tbarzic wrote:
> s/are/is/

Done.

[Devlin, 2017-05-25 16:17:15]

idl lgtm; did you need me to look at anything else?

> Greg K - Do you have any other concerns? To clarify my previous comment, we do
> not expose getCertificateLists() in the networking.onc IDL, and in
> networking_private_api.cc we also test against HasPrivateNetworkingAccess()
like
> we do for other functions that are disallowed in networking.onc to ensure that
> it can only be called from WebUI or whitelisted networkingPrivate extensions
> (i.e. chromecast).

For the record, now that this doesn't add new methods to the public API, I'm
more comfortable with it.  When I asked about the security review, we were
exposing getCertificateLists publicly.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:848: // PEM for server ca
certificatess.
typo: certificates

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:848: // PEM for server ca
certificatess.
should 'ca' be capitalized (i.e., 'CA')?

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:859: // Certificates available for
the ServerCA property.
(Similar to above) - let's pick one of 'server ca', 'server CA', 'ServerCA' and
use it everywhere (in comments, not in code)

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:860: Certificate[]
server_ca_certificates;
js-style -> serverCaCertificates

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:863: Certificate[]
user_certificates;
js-style -> userCertificates

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:1129: static void
onCertificateListsChanged();
Would it be useful to pass what changed?

[stevenjb, 2017-05-25 17:35:08]

Patchset #6 (id:100001) has been deleted

[stevenjb, 2017-05-25 17:36:01]

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:848: // PEM for server ca
certificatess.
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> should 'ca' be capitalized (i.e., 'CA')?

Done.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:848: // PEM for server ca
certificatess.
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> typo: certificates

Done.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:859: // Certificates available for
the ServerCA property.
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> (Similar to above) - let's pick one of 'server ca', 'server CA', 'ServerCA'
and
> use it everywhere (in comments, not in code)

Done.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:860: Certificate[]
server_ca_certificates;
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> js-style -> serverCaCertificates

Oops. Thanks. Done.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:863: Certificate[]
user_certificates;
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> js-style -> userCertificates

Done.

https://codereview.chromium.org/2891453002/diff/80001/extensions/common/api/n...
extensions/common/api/networking_private.idl:1129: static void
onCertificateListsChanged();
On 2017/05/25 16:17:15, Devlin (catching up) wrote:
> Would it be useful to pass what changed?

Not especially and that would require considerable bookkeeping. It currently
triggers a re-request of the certificate lists if needed.

[stevenjb, 2017-05-25 17:36:07]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-25 17:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, tbarzic@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2891453002/#ps120001
(title: "Rebase + Fix IDL comments and identifiers")

[commit-bot: I haz the power, 2017-05-25 17:36:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:54:51]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-05-25 18:41:04]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-25 18:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, isherman@chromium.org, tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/2891453002/#ps140001
(title: "Fix Linux")

[commit-bot: I haz the power, 2017-05-25 18:41:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:40:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-05-25 21:02:21]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-25 21:02:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, isherman@chromium.org, tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/2891453002/#ps180001
(title: "Clang format")

[commit-bot: I haz the power, 2017-05-25 21:02:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 23:04:52]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495746141985390,
"parent_rev": "f9ad97d4a86c4820fb02d73fb28bcd34ec4e3428", "commit_rev":
"bbb23b76fd2d8e7f864deff6e70c10bf4fddeb87"}

[commit-bot: I haz the power, 2017-05-25 23:05:02]

Description was changed from

==========
Introduce networkingPrivate.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Introduce networkingPrivate.getCertificateLists

This CL:
* Adds NetworkCertificateHandler to maintain lists of network
  certificates (Server CA and User/Client).
* Adds a ClientCertPKCS11Id property to ONC to allow configuration
  UI to use ONC to specify a PKCS#11 certificate identifier.
* Adds getCertificateLists to networkingPrivate and networking.onc.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891453002
Cr-Commit-Position: refs/heads/master@{#474836}
Committed:
https://chromium.googlesource.com/chromium/src/+/bbb23b76fd2d8e7f864deff6e70c...
==========

[commit-bot: I haz the power, 2017-05-25 23:05:04]

Committed patchset #9 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/bbb23b76fd2d8e7f864deff6e70c...