Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2891423003: CUPS: Fix the incorrect width Protocol drop down menu. (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CUPS: Fix the incorrect width Protocol drop down menu. BUG=724575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2891423003 Cr-Commit-Position: refs/heads/master@{#474718} Committed: https://chromium.googlesource.com/chromium/src/+/fbc8de4d979f168d1f5e7bd8bbf9f561349535c5

Patch Set 1 #

Patch Set 2 : Address michaelpg@'s comment. #

Patch Set 3 : Remove the left padding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks! (Please refer to the bug to ...
3 years, 7 months ago (2017-05-22 16:54:02 UTC) #5
michaelpg
On 2017/05/22 16:54:02, xdai1 wrote: > michaelpg@, could you help review this CL please? Thanks! ...
3 years, 7 months ago (2017-05-23 05:37:20 UTC) #8
xdai1
On 2017/05/23 05:37:20, michaelpg wrote: > On 2017/05/22 16:54:02, xdai1 wrote: > > michaelpg@, could ...
3 years, 7 months ago (2017-05-23 17:57:37 UTC) #9
michaelpg
On 2017/05/23 17:57:37, xdai1 wrote: > On 2017/05/23 05:37:20, michaelpg wrote: > > On 2017/05/22 ...
3 years, 7 months ago (2017-05-23 19:14:29 UTC) #10
xdai1
On 2017/05/23 19:14:29, michaelpg wrote: > > Thanks I dunno about that left padding, but ...
3 years, 7 months ago (2017-05-23 23:20:06 UTC) #11
michaelpg
yep, lgtm
3 years, 7 months ago (2017-05-24 21:39:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891423003/40001
3 years, 7 months ago (2017-05-25 17:18:00 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 18:33:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fbc8de4d979f168d1f5e7bd8bbf9...

Powered by Google App Engine
This is Rietveld 408576698