CUPS: Fix the incorrect width Protocol drop down menu.

CUPS: Fix the incorrect width Protocol drop down menu.

BUG=724575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891423003
Cr-Commit-Position: refs/heads/master@{#474718}
Committed: https://chromium.googlesource.com/chromium/src/+/fbc8de4d979f168d1f5e7bd8bbf9f561349535c5

[xdai1, 2017-05-19 18:40:33]

Description was changed from

==========
CUPS: Fix the incorrect width Protocol drop down menu.

BUG=724575
==========

to

==========
CUPS: Fix the incorrect width Protocol drop down menu.

BUG=724575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xdai1, 2017-05-22 16:41:57]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 16:42:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xdai1, 2017-05-22 16:54:02]

xdai@chromium.org changed reviewers:
+ michaelpg@chromium.org

[xdai1, 2017-05-22 16:54:02]

michaelpg@, could you help review this CL please? Thanks! (Please refer to the
bug to see the before and after screenshots.)

[commit-bot: I haz the power, 2017-05-22 18:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:37:52]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-05-23 05:37:20]

On 2017/05/22 16:54:02, xdai1 wrote:
> michaelpg@, could you help review this CL please? Thanks! (Please refer to the
> bug to see the before and after screenshots.)

This doesn't look like the right effect. We normally don't have that much
padding before the dropdown text or after the dropdown arrow -- does the
<select> control need to be made wider (or the text inputs shorter) instead?

[xdai1, 2017-05-23 17:57:37]

On 2017/05/23 05:37:20, michaelpg wrote:
> On 2017/05/22 16:54:02, xdai1 wrote:
> > michaelpg@, could you help review this CL please? Thanks! (Please refer to
the
> > bug to see the before and after screenshots.)
> 
> This doesn't look like the right effect. We normally don't have that much
> padding before the dropdown text or after the dropdown arrow -- does the
> <select> control need to be made wider (or the text inputs shorter) instead?

Modified as you suggested. Though I preserve the padding at the beginning of the
line (see screenshot in the bug). Please take another look, thanks for the
review!

[michaelpg, 2017-05-23 19:14:29]

On 2017/05/23 17:57:37, xdai1 wrote:
> On 2017/05/23 05:37:20, michaelpg wrote:
> > On 2017/05/22 16:54:02, xdai1 wrote:
> > > michaelpg@, could you help review this CL please? Thanks! (Please refer to
> the
> > > bug to see the before and after screenshots.)
> > 
> > This doesn't look like the right effect. We normally don't have that much
> > padding before the dropdown text or after the dropdown arrow -- does the
> > <select> control need to be made wider (or the text inputs shorter) instead?
> 
> Modified as you suggested. Though I preserve the padding at the beginning of
the
> line (see screenshot in the bug). Please take another look, thanks for the
> review!

Thanks I dunno about that left padding, but this change LGTM!

[xdai1, 2017-05-23 23:20:06]

On 2017/05/23 19:14:29, michaelpg wrote:
> 
> Thanks I dunno about that left padding, but this change LGTM!

Could you take another look at this CL to see if it still looks good? According
to the PM's opinion, she prefers no left white-space padding for the underline
of the dropdown list.

[michaelpg, 2017-05-24 21:39:20]

yep, lgtm

[xdai1, 2017-05-25 17:17:24]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:18:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:33:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495732644644490,
"parent_rev": "77584b488e6f147a4a0b5d75a1ceda38ff80dd08", "commit_rev":
"fbc8de4d979f168d1f5e7bd8bbf9f561349535c5"}

[commit-bot: I haz the power, 2017-05-25 18:33:55]

Description was changed from

==========
CUPS: Fix the incorrect width Protocol drop down menu.

BUG=724575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
CUPS: Fix the incorrect width Protocol drop down menu.

BUG=724575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891423003
Cr-Commit-Position: refs/heads/master@{#474718}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbc8de4d979f168d1f5e7bd8bbf9...
==========

[commit-bot: I haz the power, 2017-05-25 18:33:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fbc8de4d979f168d1f5e7bd8bbf9...