Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2891403004: Fix bug where misspelling underline is not removed properly (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 0cc79443ce04832706b604e4c999995648191ddb..f2d0452b8d8746ae81442f988f20c3fbe8add0c4 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -6649,6 +6649,16 @@ TEST_P(ParameterizedWebFrameTest, ReplaceMisspelledRange) {
WebFrameContentDumper::DumpWebViewAsText(
web_view_helper.WebView(), std::numeric_limits<size_t>::max())
.Utf8());
+
+ const int kAllNewTextBeginOffset = 0;
+ const int kAllNewTextLength = 10;
+ frame->SelectRange(WebRange(kAllNewTextBeginOffset, kAllNewTextLength));
+ selection_range = frame->GetFrame()
+ ->Selection()
+ .ComputeVisibleSelectionInDOMTreeDeprecated()
+ .ToNormalizedEphemeralRange();
+ EXPECT_EQ(0, NumMarkersInRange(document, selection_range,
+ DocumentMarker::kSpelling));
}
TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkers) {

Powered by Google App Engine
This is Rietveld 408576698