Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2891403004: Fix bug where misspelling underline is not removed properly (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index bd6fad960936c59028da2e15856885b717236563..6a800400a5973496bfc3a1533981b7f877286b49 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -838,6 +838,9 @@ void SpellChecker::ReplaceMisspelledRange(const String& text) {
if (marker_range.IsNull())
return;
+ GetFrame().GetDocument()->Markers().RemoveMarkersInRange(
yosin_UTC9 2017/05/22 05:14:10 If we decide to remove marker explicitly, I agains
+ marker_range, DocumentMarker::MisspellingMarkers());
yosin_UTC9 2017/05/22 05:14:10 I'm not sure why do we need to remove marker expli
+
GetFrame().Selection().SetSelection(
SelectionInDOMTree::Builder().SetBaseAndExtent(marker_range).Build());
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698