Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 2891393002: [scheduler] Discard anomalously long tasks and bump metrics version.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days ago by altimin
Modified:
1 hour, 39 minutes ago
Reviewers:
Ilya Sherman, Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Discard anomalously long tasks and bump metrics version. We assume that very long tasks (> 30 seconds) are a result of measurement errors such as system falling asleep in the middle of a task. R=skyostil@chromium.org,isherman@chromium.org

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed comments from skyostil@ #

Total comments: 3

Messages

Total messages: 12 (6 generated)
altimin
PTAL
3 days ago (2017-05-19 15:32:11 UTC) #3
Sami
lgtm with two changes. https://codereview.chromium.org/2891393002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2891393002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode72 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:72: "RendererScheduler.ForegroundRendererLoad2", load_percentage); I don't think ...
2 days, 23 hours ago (2017-05-19 16:11:18 UTC) #4
altimin
https://codereview.chromium.org/2891393002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2891393002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode72 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:72: "RendererScheduler.ForegroundRendererLoad2", load_percentage); On 2017/05/19 16:11:18, Sami wrote: > I ...
2 days, 23 hours ago (2017-05-19 16:20:45 UTC) #5
Ilya Sherman
https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode58 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:58: // of the task). Hmm, why are you making ...
2 days, 18 hours ago (2017-05-19 21:15:11 UTC) #8
altimin
https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode58 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:58: // of the task). On 2017/05/19 21:15:11, Ilya Sherman ...
2 days, 17 hours ago (2017-05-19 22:34:20 UTC) #11
Sami
1 hour, 39 minutes ago (2017-05-22 13:57:39 UTC) #12
https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2891393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:58:
// of the task).
FWIW the inactive renderer dialog should already be triggering for very long
tasks like these and we get crash reports when that happens (if the user agrees
to send one), so I think we should be already covered here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06