Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2891373003: cros: Fix "close" button visible during sign-in (Closed)

Created:
3 years, 7 months ago by xiyuan
Modified:
3 years, 7 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix "close" button visible during sign-in Fix a typo that leaves "close" button visible after sign-in starts. Just before we finish sign-in, login screen UI is re-enabled and if user clicks on the button at this very moment, it would trigger gaia reload which would do sign-in profile clean up. This would cause post login actions such as cookies to oauth2 token exchange failure (for SAML users). BUG=677312 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2891373003 Cr-Commit-Position: refs/heads/master@{#473418} Committed: https://chromium.googlesource.com/chromium/src/+/037910102420f21a96f535ad4e3549426dcb0f4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
xiyuan
3 years, 7 months ago (2017-05-19 21:39:54 UTC) #4
jdufault
lgtm
3 years, 7 months ago (2017-05-19 22:09:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891373003/1
3 years, 7 months ago (2017-05-20 05:23:42 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 05:28:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/037910102420f21a96f535ad4e35...

Powered by Google App Engine
This is Rietveld 408576698