Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2891373002: Use SkPngEncoder and SkWebpEncoder in WebKit platform (Closed)

Created:
3 years, 7 months ago by msarett
Modified:
3 years, 7 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkPngEncoder and SkWebpEncoder in WebKit platform The motivations for using Skia encoders are: ***Support for embedding ICC profiles ***Support for linear unpremultiplication and blending ***Support for multiple color types (including F16) ***Support for multiple alpha types As a long term refactoring goal, we should be able to delete the WebKit image encoders and the ui/gfx image encoders, thus leaving one set of image encoders to maintain. BUG=713862 Review-Url: https://codereview.chromium.org/2891373002 Cr-Commit-Position: refs/heads/master@{#473985} Committed: https://chromium.googlesource.com/chromium/src/+/217d81bc49377c2235b8325a2f03dfce9ef45f95

Patch Set 1 #

Patch Set 2 : Delete unused files #

Patch Set 3 : Adjust comments #

Total comments: 10

Patch Set 4 : Response to comments #

Messages

Total messages: 24 (17 generated)
msarett1
3 years, 7 months ago (2017-05-19 16:53:48 UTC) #5
scroggo_chromium
lgtm https://codereview.chromium.org/2891373002/diff/40001/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp File third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/2891373002/diff/40001/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp#newcode548 third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp:548: SkImageInfo::Make(Width(), Height(), kRGBA_8888_SkColorType, It seems weird to me ...
3 years, 7 months ago (2017-05-22 13:35:04 UTC) #12
msarett1
https://codereview.chromium.org/2891373002/diff/40001/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp File third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/2891373002/diff/40001/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp#newcode548 third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp:548: SkImageInfo::Make(Width(), Height(), kRGBA_8888_SkColorType, On 2017/05/22 13:35:04, scroggo_chromium wrote: > ...
3 years, 7 months ago (2017-05-22 15:33:56 UTC) #13
scroggo_chromium
LGTM, thanks!
3 years, 7 months ago (2017-05-22 18:15:33 UTC) #14
f(malita)
LGTM
3 years, 7 months ago (2017-05-23 14:40:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891373002/60001
3 years, 7 months ago (2017-05-23 18:12:14 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:20:02 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/217d81bc49377c2235b8325a2f03...

Powered by Google App Engine
This is Rietveld 408576698