Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2891343003: [Home] Make the new NTP over the tab switcher design the default (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones, Ted C
CC:
chromium-reviews, noyau+watch_chromium.org, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Make the new NTP over the tab switcher design the default Removes the flags guarding the new NTP over the tab switcher design and replaces ChromeHomeNewTabPageTest with BottomSheetNewTabControllerTest. BUG=695973 Review-Url: https://codereview.chromium.org/2891343003 Cr-Commit-Position: refs/heads/master@{#473751} Committed: https://chromium.googlesource.com/chromium/src/+/075c148ae5e1e965596c1456c68704c1443df3e6

Patch Set 1 #

Patch Set 2 : [Home] Make the new NTP over the tab switcher design the default #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -250 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 4 chunks +2 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageTest.java View 1 chunk +0 lines, -216 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java View 1 chunk +232 lines, -0 lines 1 comment Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeTabUtils.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Theresa
ptal https://codereview.chromium.org/2891343003/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java (right): https://codereview.chromium.org/2891343003/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java#newcode80 chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java:80: // The sheet should now be closed and ...
3 years, 7 months ago (2017-05-19 19:07:24 UTC) #4
mdjones
lgtm
3 years, 7 months ago (2017-05-22 21:34:13 UTC) #7
Theresa
+tedchoc@ for OWNERS
3 years, 7 months ago (2017-05-22 21:46:02 UTC) #9
Ted C
lgtm
3 years, 7 months ago (2017-05-22 22:49:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891343003/20001
3 years, 7 months ago (2017-05-22 22:55:19 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 00:00:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/075c148ae5e1e965596c1456c687...

Powered by Google App Engine
This is Rietveld 408576698