Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2891343002: Reduce temporarily flakiness rate of dart2js-drt by re-running until they have been fixed (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 57c3cb758d78ff3870b788190d23a1f057cb531c..ac96f01d3faafa463f7840ce0f619aa40f736e0b 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2982,6 +2982,14 @@ bool shouldRetryCommand(CommandOutput output) {
return true;
}
+ // As long as we use a legacy version of our custom content_shell (which
+ // became quite flaky after chrome-50 roll) we'll re-run tests on it.
+ // The plan is to use chrome's content_shell instead of our own.
+ // See http://dartbug.com/29655 .
+ if (command is ContentShellCommand) {
+ return true;
+ }
+
if (io.Platform.operatingSystem == 'linux') {
decodeOutput();
// No matter which command we ran: If we get failures due to the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698