Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 2891343002: Reduce temporarily flakiness rate of dart2js-drt by re-running until they have been fixed (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 2964 matching lines...) Expand 10 before | Expand all | Expand 10 after
2975 } 2975 }
2976 } 2976 }
2977 2977
2978 // We currently rerun dartium tests, see issue 14074. 2978 // We currently rerun dartium tests, see issue 14074.
2979 if (command is BrowserTestCommand && 2979 if (command is BrowserTestCommand &&
2980 command.retry && 2980 command.retry &&
2981 command.browser == 'dartium') { 2981 command.browser == 'dartium') {
2982 return true; 2982 return true;
2983 } 2983 }
2984 2984
2985 // As long as we use a legacy version of our custom content_shell (which
2986 // became quite flaky after chrome-50 roll) we'll re-run tests on it.
2987 // The plan is to use chrome's content_shell instead of our own.
2988 // See http://dartbug.com/29655 .
2989 if (command is ContentShellCommand) {
2990 return true;
2991 }
2992
2985 if (io.Platform.operatingSystem == 'linux') { 2993 if (io.Platform.operatingSystem == 'linux') {
2986 decodeOutput(); 2994 decodeOutput();
2987 // No matter which command we ran: If we get failures due to the 2995 // No matter which command we ran: If we get failures due to the
2988 // "xvfb-run" issue 7564, try re-running the test. 2996 // "xvfb-run" issue 7564, try re-running the test.
2989 bool containsFailureMsg(String line) { 2997 bool containsFailureMsg(String line) {
2990 return line.contains(MESSAGE_CANNOT_OPEN_DISPLAY) || 2998 return line.contains(MESSAGE_CANNOT_OPEN_DISPLAY) ||
2991 line.contains(MESSAGE_FAILED_TO_RUN_COMMAND); 2999 line.contains(MESSAGE_FAILED_TO_RUN_COMMAND);
2992 } 3000 }
2993 3001
2994 if (stdout.any(containsFailureMsg) || stderr.any(containsFailureMsg)) { 3002 if (stdout.any(containsFailureMsg) || stderr.any(containsFailureMsg)) {
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
3291 } 3299 }
3292 } 3300 }
3293 3301
3294 void eventAllTestsDone() { 3302 void eventAllTestsDone() {
3295 for (var listener in _eventListener) { 3303 for (var listener in _eventListener) {
3296 listener.allDone(); 3304 listener.allDone();
3297 } 3305 }
3298 _allDone(); 3306 _allDone();
3299 } 3307 }
3300 } 3308 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698