Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: components/favicon/core/favicon_driver_impl.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)
Patch Set: Updated iOS code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.cc
diff --git a/components/favicon/core/favicon_driver_impl.cc b/components/favicon/core/favicon_driver_impl.cc
index 545def8f27886a2ff8997d8acd3f54d2f0b2953f..6b92e684cec3a9df89bb2a3512e96eaea916f9ce 100644
--- a/components/favicon/core/favicon_driver_impl.cc
+++ b/components/favicon/core/favicon_driver_impl.cc
@@ -106,7 +106,7 @@ void FaviconDriverImpl::OnUpdateCandidates(
// FAVICON, because those compete which each other (i.e. manifest icons
// override inline favicons).
pkotwicz 2017/05/26 14:49:56 You need to update this comment
mastiz 2017/05/26 18:30:25 Done.
handler->OnUpdateCandidates(page_url, candidates,
- handler->icon_types() & favicon_base::FAVICON
+ handler->icon_types() & favicon_base::TOUCH_ICON
pkotwicz 2017/05/26 14:49:56 Might as well make this WEB_MANIFEST_ICON
mastiz 2017/05/26 18:30:25 Done.
? manifest_url
: GURL::EmptyGURL());
}
« no previous file with comments | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698