Introduce dedicated enum value for icons from Web Manifests

components/favicon/core/favicon_driver_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_driver_impl.h"
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
@@ skipping 86 matching lines @@
 }
 
 void FaviconDriverImpl::OnUpdateCandidates(
     const GURL& page_url,
     const std::vector<FaviconURL>& candidates,
     const GURL& manifest_url) {
   RecordCandidateMetrics(candidates);
   for (const std::unique_ptr<FaviconHandler>& handler : handlers_) {
     // We feed in the Web Manifest URL (if any) to the instance handling type
     // FAVICON, because those compete which each other (i.e. manifest icons
     // override inline favicons).

[pkotwicz, 2017/05/26 14:49:56]

You need to update this comment

[mastiz, 2017/05/26 18:30:25]

Done.

     handler->OnUpdateCandidates(page_url, candidates,
-                                handler->icon_types() & favicon_base::FAVICON
+                                handler->icon_types() & favicon_base::TOUCH_ICON

[pkotwicz, 2017/05/26 14:49:56]

Might as well make this WEB_MANIFEST_ICON

[mastiz, 2017/05/26 18:30:25]

Done.

                                     ? manifest_url
                                     : GURL::EmptyGURL());
   }
 }
 
 }  // namespace favicon