chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc - Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)

Patch Set: Updated iOS code. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | components/favicon/content/content_favicon_driver.cc » ('j') | components/favicon/core/favicon_driver_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

diff --git a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

index a076845bfe29b2c019630adab86fe405a66b566a..3edb9f5ddaed01f24b110a9122b3a40c249f8397 100644

--- a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

+++ b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

@@ -60,6 +60,7 @@ std::unique_ptr<SearchResult> URLSuggestionResult::Duplicate() const {

void URLSuggestionResult::UpdateIcon() {

std::vector<int> icon_types;

+ icon_types.push_back(favicon_base::IconType::WEB_MANIFEST_ICON);

icon_types.push_back(favicon_base::IconType::FAVICON);

icon_types.push_back(favicon_base::IconType::TOUCH_ICON);

icon_types.push_back(favicon_base::IconType::TOUCH_PRECOMPOSED_ICON);