Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)
Patch Set: Updated iOS code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index a67b5687190cb61817766e6f55b7865affe12644..e5f3bc8762e6a643138a6cdda0056b39e99880f3 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -264,7 +264,7 @@ void AddToHomescreenDataFetcher::FetchFavicon() {
// TODO(dfalcantara): Try combining with the new BookmarksHandler once its
// rewrite is further along.
std::vector<int> icon_types{
- favicon_base::FAVICON,
+ favicon_base::WEB_MANIFEST_ICON, favicon_base::FAVICON,
favicon_base::TOUCH_PRECOMPOSED_ICON | favicon_base::TOUCH_ICON};
favicon::FaviconService* favicon_service =

Powered by Google App Engine
This is Rietveld 408576698