components/favicon/core/favicon_driver_impl.cc - Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_driver_impl.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_driver_impl.cc

diff --git a/components/favicon/core/favicon_driver_impl.cc b/components/favicon/core/favicon_driver_impl.cc

index 545def8f27886a2ff8997d8acd3f54d2f0b2953f..6b92e684cec3a9df89bb2a3512e96eaea916f9ce 100644

--- a/components/favicon/core/favicon_driver_impl.cc

+++ b/components/favicon/core/favicon_driver_impl.cc

@@ -106,7 +106,7 @@ void FaviconDriverImpl::OnUpdateCandidates(

// FAVICON, because those compete which each other (i.e. manifest icons

// override inline favicons).

handler->OnUpdateCandidates(page_url, candidates,

- handler->icon_types() & favicon_base::FAVICON

+ handler->icon_types() & favicon_base::TOUCH_ICON

? manifest_url

: GURL::EmptyGURL());

}