Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5968)

Unified Diff: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc
diff --git a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc
index a076845bfe29b2c019630adab86fe405a66b566a..3edb9f5ddaed01f24b110a9122b3a40c249f8397 100644
--- a/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc
+++ b/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc
@@ -60,6 +60,7 @@ std::unique_ptr<SearchResult> URLSuggestionResult::Duplicate() const {
void URLSuggestionResult::UpdateIcon() {
std::vector<int> icon_types;
+ icon_types.push_back(favicon_base::IconType::WEB_MANIFEST_ICON);
pkotwicz 2017/05/24 14:27:44 You also need to update: - AddToHomescreenDataFetc
mastiz 2017/05/25 11:14:16 Done. Mac can be addressed in follow-up CLs since
icon_types.push_back(favicon_base::IconType::FAVICON);
icon_types.push_back(favicon_base::IconType::TOUCH_ICON);
icon_types.push_back(favicon_base::IconType::TOUCH_PRECOMPOSED_ICON);
« no previous file with comments | « no previous file | components/favicon/core/favicon_driver_impl.cc » ('j') | components/favicon/core/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698