Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2891263003: Manually revert only showing search geo disclosure after EULA accepted (Closed)

Created:
3 years, 7 months ago by benwells
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually revert only showing search geo disclosure after EULA accepted Now that the disclosure is only shown when the X-Geo header is sent, or a page uses the geolocation API, this isn't needed. The change which prevented the disclosure being shown until after EULA was accepted also apparently caused a perf regression. It's hard to see how it would have, but removingt the change will determine if it really was that change or something else. BUG=714863 Review-Url: https://codereview.chromium.org/2891263003 Cr-Commit-Position: refs/heads/master@{#473298} Committed: https://chromium.googlesource.com/chromium/src/+/af4727a9a29c33197e12a7284b9ecad63422b081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/android/search_geolocation/search_geolocation_service.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
benwells
Dan reviewed the original change, but he is OOO
3 years, 7 months ago (2017-05-19 05:27:07 UTC) #6
Ted C
lgtm
3 years, 7 months ago (2017-05-19 17:14:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891263003/1
3 years, 7 months ago (2017-05-19 20:27:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 20:35:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af4727a9a29c33197e12a7284b9e...

Powered by Google App Engine
This is Rietveld 408576698