chromeos: removes WmWindow usage from MultiWindowResizeController

chromeos: removes WmWindow usage from MultiWindowResizeController

BUG=722553
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2891183002
Cr-Commit-Position: refs/heads/master@{#472978}
Committed: https://chromium.googlesource.com/chromium/src/+/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8

[sky, 2017-05-18 21:33:34]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 21:35:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-18 22:28:05]

lgtm with nits

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller.cc:41:
::wm::ConvertPointFromScreen(window, &result);
aside: we should consider adding these helpers to aura::Window, or maybe we
could just inline |point +/- window->GetBoundsInScreen().origin()|, I'm not sure
why |::wm::ConvertPointFromScreen| is more complex than that.

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller.cc:338: const
std::vector<aura::Window*>& windows = parent->children();
optional nit: use aura::Window::Windows? ditto elsewhere.

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
File ash/wm/workspace/multi_window_resize_controller_unittest.cc (right):

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller_unittest.cc:88: if
((resize_controller_->windows_.window1 == window ||
nit: remove extra parens, optionally add curlies.

[sky, 2017-05-18 22:40:15]

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller.cc:41:
::wm::ConvertPointFromScreen(window, &result);
On 2017/05/18 22:28:04, msw wrote:
> aside: we should consider adding these helpers to aura::Window, or maybe we
> could just inline |point +/- window->GetBoundsInScreen().origin()|, I'm not
sure
> why |::wm::ConvertPointFromScreen| is more complex than that.

Agreed, but I'll do that separately.

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller.cc:338: const
std::vector<aura::Window*>& windows = parent->children();
On 2017/05/18 22:28:04, msw wrote:
> optional nit: use aura::Window::Windows? ditto elsewhere.

Done.

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
File ash/wm/workspace/multi_window_resize_controller_unittest.cc (right):

https://codereview.chromium.org/2891183002/diff/20001/ash/wm/workspace/multi_...
ash/wm/workspace/multi_window_resize_controller_unittest.cc:88: if
((resize_controller_->windows_.window1 == window ||
On 2017/05/18 22:28:04, msw wrote:
> nit: remove extra parens, optionally add curlies.

Done.

[sky, 2017-05-18 22:40:23]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-18 22:40:23]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2891183002/#ps40001
(title: "feedback and merge")

[commit-bot: I haz the power, 2017-05-18 22:40:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 23:50:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495147223090670,
"parent_rev": "7b2e4083e4407bd1220f4e814cc4fe1d9c3beb3f", "commit_rev":
"4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8"}

[commit-bot: I haz the power, 2017-05-18 23:50:43]

Description was changed from

==========
chromeos: removes WmWindow usage from MultiWindowResizeController

BUG=722553
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
chromeos: removes WmWindow usage from MultiWindowResizeController

BUG=722553
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2891183002
Cr-Commit-Position: refs/heads/master@{#472978}
Committed:
https://chromium.googlesource.com/chromium/src/+/4befdb0d6d0896948df1f5d3a7fc...
==========

[commit-bot: I haz the power, 2017-05-18 23:50:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4befdb0d6d0896948df1f5d3a7fc...