Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2891163002: [MD settings] explain when no usb devices are shown in site settings (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
srahim, hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] explain when no usb devices are shown in site settings This CL shows an explanation in the USB devices content settings page when no USB devices are found. (So that the page is not blank, which looks/looked broken). BUG=713428 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2891163002 Cr-Commit-Position: refs/heads/master@{#473301} Committed: https://chromium.googlesource.com/chromium/src/+/e2c35ba3891bb703bbc67c57d63b6c0a2299131d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.js View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dschuyler
3 years, 7 months ago (2017-05-18 20:34:57 UTC) #4
dschuyler
On 2017/05/18 20:34:57, dschuyler wrote: I added a screen shot of the explanation in the ...
3 years, 7 months ago (2017-05-18 20:36:56 UTC) #6
srahim
On 2017/05/18 20:36:56, dschuyler wrote: > On 2017/05/18 20:34:57, dschuyler wrote: > > I added ...
3 years, 7 months ago (2017-05-19 18:14:45 UTC) #9
hcarmona
lgtm
3 years, 7 months ago (2017-05-19 18:19:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891163002/1
3 years, 7 months ago (2017-05-19 19:29:00 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 20:37:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2c35ba3891bb703bbc67c57d63b...

Powered by Google App Engine
This is Rietveld 408576698