RELAND: Shape Detection: Face detection junit tests

RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.

TBR=rockot@chromium.org, scheib@chromium.org since it's a strict subset 
of the reviewed-approved CL.

Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed: https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3c355e19a9f3d

patch from issue 2863773005 at patchset 180001 (http://crrev.com/2863773005#ps180001)

Review-Url: https://codereview.chromium.org/2891153003
Cr-Commit-Position: refs/heads/master@{#473045}
Committed: https://chromium.googlesource.com/chromium/src/+/440ee8acf5fc2995762db08f722aa060b14a5e5d

[mcasas, 2017-05-18 23:35:26]

Description was changed from

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.


Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)
==========

to

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.


Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)
==========

[mcasas, 2017-05-18 23:36:17]

Description was changed from

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.


Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)
==========

to

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.

TBR=rockot@chromium.org, scheib@chromium.org since it's a strict subset 
of the reviewed-approved CL.

Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)
==========

[mcasas, 2017-05-19 00:37:49]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:38:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:49:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495154269013920,
"parent_rev": "98d6a9265c7568b2b55c0cb1d4bed6fbffec5f76", "commit_rev":
"440ee8acf5fc2995762db08f722aa060b14a5e5d"}

[commit-bot: I haz the power, 2017-05-19 02:50:01]

Description was changed from

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.

TBR=rockot@chromium.org, scheib@chromium.org since it's a strict subset 
of the reviewed-approved CL.

Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)
==========

to

==========
RELAND: Shape Detection: Face detection junit tests


The original CL got reverted due to a given test timing out in bots
(might be slow).  This CL, in the interest of increasing coverage,
lands the part that worked fine: SharedBufferUtilsTest.java, and removes
the FaceDetectionImplTest.java and mods to FaceDetectionImpl.java.

TBR=rockot@chromium.org, scheib@chromium.org since it's a strict subset 
of the reviewed-approved CL.

Original CL -----------------------------------------------------------

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases.
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

patch from issue 2863773005 at patchset 180001
(http://crrev.com/2863773005#ps180001)

Review-Url: https://codereview.chromium.org/2891153003
Cr-Commit-Position: refs/heads/master@{#473045}
Committed:
https://chromium.googlesource.com/chromium/src/+/440ee8acf5fc2995762db08f722a...
==========

[commit-bot: I haz the power, 2017-05-19 02:50:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/440ee8acf5fc2995762db08f722a...