Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2891143002: [ObjC ARC] Converts ios/chrome/test/ocmock:ocmock to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 6 months ago
Reviewers:
baxley, stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/test/ocmock:ocmock to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891143002 Cr-Commit-Position: refs/heads/master@{#479492} Committed: https://chromium.googlesource.com/chromium/src/+/e358d56b03f0c9bb4944bdafdf4bd0e1d4c65b39

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/test/ocmock/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
liaoyuke
Hey Stepan, PTAL. Thank you very much!
3 years, 6 months ago (2017-06-14 00:15:29 UTC) #6
stkhapugin
lgtm after comments https://codereview.chromium.org/2891143002/diff/1/ios/chrome/test/ocmock/BUILD.gn File ios/chrome/test/ocmock/BUILD.gn (right): https://codereview.chromium.org/2891143002/diff/1/ios/chrome/test/ocmock/BUILD.gn#newcode11 ios/chrome/test/ocmock/BUILD.gn:11: "scoped_mock_object.h", These two scoped_*mock_object.h" files cannot ...
3 years, 6 months ago (2017-06-14 16:54:21 UTC) #7
liaoyuke
Hey Mike, Could you please do an owner's approval? Thanks! https://codereview.chromium.org/2891143002/diff/1/ios/chrome/test/ocmock/BUILD.gn File ios/chrome/test/ocmock/BUILD.gn (right): https://codereview.chromium.org/2891143002/diff/1/ios/chrome/test/ocmock/BUILD.gn#newcode11 ...
3 years, 6 months ago (2017-06-14 18:19:25 UTC) #9
baxley
lgtm
3 years, 6 months ago (2017-06-14 18:47:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891143002/40001
3 years, 6 months ago (2017-06-14 18:57:33 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 20:36:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e358d56b03f0c9bb4944bdafdf4b...

Powered by Google App Engine
This is Rietveld 408576698