Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2891133003: Reporting: Wire ReportingDelegate into ChromeNetworkDelegate (Closed)

Created:
3 years, 7 months ago by Julia Tuttle
Modified:
3 years, 7 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Wire ReportingDelegate into ChromeNetworkDelegate Add, implement, and call some methods in NetworkDelegate to check whether sites are allowed to store reports and clients. BUG=704259, 676324 Review-Url: https://codereview.chromium.org/2891133003 Cr-Commit-Position: refs/heads/master@{#473917} Committed: https://chromium.googlesource.com/chromium/src/+/fcf472038605e8554a6c7e75f0f159ebdaa73299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -13 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 2 chunks +22 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M net/base/network_delegate.h View 3 chunks +21 lines, -0 lines 0 comments Download
M net/base/network_delegate.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.h View 2 chunks +14 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/reporting/reporting_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/reporting/reporting_context.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/reporting/reporting_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/reporting/reporting_delegate.cc View 2 chunks +28 lines, -7 lines 0 comments Download
M net/reporting/reporting_test_util.h View 3 chunks +26 lines, -0 lines 0 comments Download
M net/reporting/reporting_test_util.cc View 2 chunks +25 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 7 months ago (2017-05-18 19:57:43 UTC) #3
shivanisha
On 2017/05/18 at 19:57:43, juliatuttle wrote: > PTAL, shivanisha. lgtm.
3 years, 7 months ago (2017-05-19 19:58:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891133003/1
3 years, 7 months ago (2017-05-23 14:19:26 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 15:53:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcf472038605e8554a6c7e75f0f1...

Powered by Google App Engine
This is Rietveld 408576698