Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2891133002: [ObjC ARC] Converts ios/chrome/browser/native_app_launcher:unit_tests_internal to ARC. (Closed)

Created:
3 years, 7 months ago by lindsayw
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/native_app_launcher:unit_tests_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891133002 Cr-Commit-Position: refs/heads/master@{#475623} Committed: https://chromium.googlesource.com/chromium/src/+/d4155b65286de81b9c71e96d6ec5e1f3b22e6230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm View 7 chunks +18 lines, -18 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
lindsayw
Thanks for the review!
3 years, 7 months ago (2017-05-19 12:01:47 UTC) #6
lindsayw
Hi Rohit, Can you please review since Paris is out and you are owner? Thanks!
3 years, 7 months ago (2017-05-25 14:55:34 UTC) #8
stkhapugin
lgtm
3 years, 6 months ago (2017-05-30 13:29:49 UTC) #11
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-05-30 15:01:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891133002/1
3 years, 6 months ago (2017-05-30 17:28:11 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:13:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d4155b65286de81b9c71e96d6ec5...

Powered by Google App Engine
This is Rietveld 408576698