Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2891103002: [Content suggestions favicons] Let the clients rescale the gfx::Image (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days, 23 hours ago by jkrcal
Modified:
3 days ago
Reviewers:
fhorschig
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Content suggestions favicons] Let the clients rescale the gfx::Image This CL improves quality of icons by letting clients (Android / iOS) resize the icons to desired size. The icons look much crisper than when resized by LargeIconService (that uses a crappy resampling technique). The CL polishes the code a bit so that there is only 1 call site for LargeIconService::GetLargeIconImageOrFallbackStyle(). BUG=692975 Review-Url: https://codereview.chromium.org/2891103002 Cr-Commit-Position: refs/heads/master@{#473199} Committed: https://chromium.googlesource.com/chromium/src/+/95acdc5a58015c3aefac2f05af19717ba104cae3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Friedrich's comments #

Messages

Total messages: 19 (12 generated)
jkrcal
Friedrich, could you PTAL?
3 days, 23 hours ago (2017-05-18 16:14:58 UTC) #2
fhorschig
lgtm with comments about comments https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/content_suggestions_service.cc File components/ntp_snippets/content_suggestions_service.cc (right): https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/content_suggestions_service.cc#newcode207 components/ntp_snippets/content_suggestions_service.cc:207: // TODO(jkrcal): Create a ...
3 days, 7 hours ago (2017-05-19 08:17:46 UTC) #7
jkrcal
Thanks! https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/content_suggestions_service.cc File components/ntp_snippets/content_suggestions_service.cc (right): https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/content_suggestions_service.cc#newcode207 components/ntp_snippets/content_suggestions_service.cc:207: // TODO(jkrcal): Create a general wrapper function in ...
3 days, 4 hours ago (2017-05-19 11:36:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891103002/20001
3 days, 4 hours ago (2017-05-19 11:37:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431756)
3 days, 2 hours ago (2017-05-19 13:19:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891103002/20001
3 days ago (2017-05-19 15:00:42 UTC) #15
commit-bot: I haz the power
3 days ago (2017-05-19 15:35:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/95acdc5a58015c3aefac2f05af19...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06