[Content suggestions favicons] Let the clients rescale the gfx::Image

[Content suggestions favicons] Let the clients rescale the gfx::Image

This CL improves quality of icons by letting clients (Android / iOS)
resize the icons to desired size. The icons look much crisper than when
resized by LargeIconService (that uses a crappy resampling technique).

The CL polishes the code a bit so that there is only 1 call site for
LargeIconService::GetLargeIconImageOrFallbackStyle().

BUG=692975
Review-Url: https://codereview.chromium.org/2891103002
Cr-Commit-Position: refs/heads/master@{#473199}
Committed: https://chromium.googlesource.com/chromium/src/+/95acdc5a58015c3aefac2f05af19717ba104cae3

[jkrcal, 2017-05-18 16:14:57]

jkrcal@chromium.org changed reviewers:
+ fhorschig@chromium.org

[jkrcal, 2017-05-18 16:14:58]

Friedrich, could you PTAL?

[jkrcal, 2017-05-18 16:15:03]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:16:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 19:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:25:23]

Dry run: This issue passed the CQ dry run.

[fhorschig, 2017-05-19 08:17:46]

lgtm with comments about comments

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:207: // TODO(jkrcal):
Create a general wrapper function in LargeIconService that
Isn't that what you did? Why is this TODO still here?

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.h (right):

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.h:336: void
GetFaviconFromCache(const GURL& publisher_url,
The comment above seems weird now. Have you been meaning to move 
the new function up one line?

[jkrcal, 2017-05-19 11:36:40]

Thanks!

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:207: // TODO(jkrcal):
Create a general wrapper function in LargeIconService that
On 2017/05/19 08:17:45, fhorschig wrote:
> Isn't that what you did? Why is this TODO still here?

No, this TODO means something different (basically, avoiding the sequence of
functions that are implemented in this file).

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.h (right):

https://codereview.chromium.org/2891103002/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.h:336: void
GetFaviconFromCache(const GURL& publisher_url,
On 2017/05/19 08:17:45, fhorschig wrote:
> The comment above seems weird now. Have you been meaning to move 
> the new function up one line? 

Done.

[jkrcal, 2017-05-19 11:37:02]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-05-19 11:37:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
fhorschig@chromium.org
Link to the patchset: https://codereview.chromium.org/2891103002/#ps20001
(title: "Friedrich's comments")

[commit-bot: I haz the power, 2017-05-19 11:37:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 13:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:19:58]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jkrcal, 2017-05-19 15:00:08]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2017-05-19 15:00:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 15:34:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495206008935800,
"parent_rev": "f8a3ddf0546af55ee59924af78370c2b8dd57fd4", "commit_rev":
"09a291ef7ae17648a650916bf29c29d61d32dea4"}

[commit-bot: I haz the power, 2017-05-19 15:34:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495206008935800,
"parent_rev": "8a539dd4fc8b43c58f6119df8fe07a20013fbab0", "commit_rev":
"95acdc5a58015c3aefac2f05af19717ba104cae3"}

[commit-bot: I haz the power, 2017-05-19 15:35:06]

Description was changed from

==========
[Content suggestions favicons] Let the clients rescale the gfx::Image

This CL improves quality of icons by letting clients (Android / iOS)
resize the icons to desired size. The icons look much crisper than when
resized by LargeIconService (that uses a crappy resampling technique).

The CL polishes the code a bit so that there is only 1 call site for
LargeIconService::GetLargeIconImageOrFallbackStyle().

BUG=692975
==========

to

==========
[Content suggestions favicons] Let the clients rescale the gfx::Image

This CL improves quality of icons by letting clients (Android / iOS)
resize the icons to desired size. The icons look much crisper than when
resized by LargeIconService (that uses a crappy resampling technique).

The CL polishes the code a bit so that there is only 1 call site for
LargeIconService::GetLargeIconImageOrFallbackStyle().

BUG=692975

Review-Url: https://codereview.chromium.org/2891103002
Cr-Commit-Position: refs/heads/master@{#473199}
Committed:
https://chromium.googlesource.com/chromium/src/+/95acdc5a58015c3aefac2f05af19...
==========

[commit-bot: I haz the power, 2017-05-19 15:35:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/95acdc5a58015c3aefac2f05af19...