Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: extensions/browser/api/cast_channel/cast_socket_service_unittest.cc

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
diff --git a/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc b/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..08e2e08de2b7608e7dd0b340d62837affc348ba3
--- /dev/null
+++ b/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
@@ -0,0 +1,81 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/api/cast_channel/cast_socket_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/api/cast_channel/cast_test_util.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+using testing::SaveArg;
+
+namespace extensions {
+namespace api {
+namespace cast_channel {
+
+class CastSocketServiceTest : public testing::Test {
+ public:
+ CastSocketServiceTest()
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
+
+ protected:
+ content::TestBrowserThreadBundle thread_bundle_;
+ CastSocketService cast_socket_service_;
+};
+
+TEST_F(CastSocketServiceTest, TestAddSocket) {
+ auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();
+
+ int channel_id_1 = 0;
+ auto socket1 = base::MakeUnique<MockCastSocket>();
+ EXPECT_CALL(*socket1, set_id(_)).WillOnce(SaveArg<0>(&channel_id_1));
+
+ int channel_id = registry->AddSocket(std::move(socket1));
+ EXPECT_EQ(channel_id_1, channel_id);
+ EXPECT_NE(0, channel_id_1);
+
+ int channel_id_2 = 0;
+ auto socket2 = base::MakeUnique<MockCastSocket>();
+ EXPECT_CALL(*socket2, set_id(_)).WillOnce(SaveArg<0>(&channel_id_2));
+
+ auto* socket_ptr = socket2.get();
+ channel_id = registry->AddSocket(std::move(socket2));
+ EXPECT_EQ(channel_id_2, channel_id);
+ EXPECT_NE(channel_id_1, channel_id_2);
+
+ auto removed_socket = registry->RemoveSocket(channel_id);
+ EXPECT_EQ(socket_ptr, removed_socket.get());
+
+ int channel_id_3 = 0;
+ auto socket3 = base::MakeUnique<MockCastSocket>();
+ EXPECT_CALL(*socket3, set_id(_)).WillOnce(SaveArg<0>(&channel_id_3));
+
+ channel_id = registry->AddSocket(std::move(socket3));
+ EXPECT_EQ(channel_id_3, channel_id);
+ EXPECT_NE(channel_id_1, channel_id_3);
+ EXPECT_NE(channel_id_2, channel_id_3);
+}
+
+TEST_F(CastSocketServiceTest, TestRemoveAndGetSocket) {
+ auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();
+ int channel_id = 1;
+ auto* socket_ptr = registry->GetSocket(channel_id);
+ EXPECT_FALSE(socket_ptr);
+ auto socket = registry->RemoveSocket(channel_id);
+ EXPECT_FALSE(socket);
+
+ auto mock_socket = base::MakeUnique<MockCastSocket>();
+ EXPECT_CALL(*mock_socket, set_id(_));
+
+ auto* mock_socket_ptr = mock_socket.get();
+ channel_id = registry->AddSocket(std::move(mock_socket));
+ EXPECT_EQ(mock_socket_ptr, registry->GetSocket(channel_id));
+ socket = registry->RemoveSocket(channel_id);
+ EXPECT_TRUE(socket);
+}
+
+} // namespace cast_channel
+} // namespace api
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698