Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: extensions/browser/api/cast_channel/cast_socket_service_unittest.cc

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "extensions/browser/api/cast_channel/cast_socket_service.h"
6 #include "content/public/test/test_browser_thread_bundle.h"
7 #include "extensions/browser/api/cast_channel/cast_test_util.h"
8
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 using testing::_;
12 using testing::SaveArg;
13
14 namespace extensions {
15 namespace api {
16 namespace cast_channel {
17
18 class CastSocketServiceTest : public testing::Test {
19 public:
20 CastSocketServiceTest()
21 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
22
23 protected:
24 content::TestBrowserThreadBundle thread_bundle_;
25 CastSocketService cast_socket_service_;
26 };
27
28 TEST_F(CastSocketServiceTest, TestAddSocket) {
29 auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();
30
31 int channel_id_1 = 0;
32 auto socket1 = base::MakeUnique<MockCastSocket>();
33 EXPECT_CALL(*socket1, set_id(_)).WillOnce(SaveArg<0>(&channel_id_1));
34
35 int channel_id = registry->AddSocket(std::move(socket1));
36 EXPECT_EQ(channel_id_1, channel_id);
37 EXPECT_NE(0, channel_id_1);
38
39 int channel_id_2 = 0;
40 auto socket2 = base::MakeUnique<MockCastSocket>();
41 EXPECT_CALL(*socket2, set_id(_)).WillOnce(SaveArg<0>(&channel_id_2));
42
43 auto* socket_ptr = socket2.get();
44 channel_id = registry->AddSocket(std::move(socket2));
45 EXPECT_EQ(channel_id_2, channel_id);
46 EXPECT_NE(channel_id_1, channel_id_2);
47
48 auto removed_socket = registry->RemoveSocket(channel_id);
49 EXPECT_EQ(socket_ptr, removed_socket.get());
50
51 int channel_id_3 = 0;
52 auto socket3 = base::MakeUnique<MockCastSocket>();
53 EXPECT_CALL(*socket3, set_id(_)).WillOnce(SaveArg<0>(&channel_id_3));
54
55 channel_id = registry->AddSocket(std::move(socket3));
56 EXPECT_EQ(channel_id_3, channel_id);
57 EXPECT_NE(channel_id_1, channel_id_3);
58 EXPECT_NE(channel_id_2, channel_id_3);
59 }
60
61 TEST_F(CastSocketServiceTest, TestRemoveAndGetSocket) {
62 auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();
63 int channel_id = 1;
64 auto* socket_ptr = registry->GetSocket(channel_id);
65 EXPECT_FALSE(socket_ptr);
66 auto socket = registry->RemoveSocket(channel_id);
67 EXPECT_FALSE(socket);
68
69 auto mock_socket = base::MakeUnique<MockCastSocket>();
70 EXPECT_CALL(*mock_socket, set_id(_));
71
72 auto* mock_socket_ptr = mock_socket.get();
73 channel_id = registry->AddSocket(std::move(mock_socket));
74 EXPECT_EQ(mock_socket_ptr, registry->GetSocket(channel_id));
75 socket = registry->RemoveSocket(channel_id);
76 EXPECT_TRUE(socket);
77 }
78
79 } // namespace cast_channel
80 } // namespace api
81 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698