extensions/browser/api/cast_channel/cast_test_util.h - Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_test_util.h

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)

Patch Set: resolve code review comments from Mark Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_test_util.h

diff --git a/extensions/browser/api/cast_channel/cast_test_util.h b/extensions/browser/api/cast_channel/cast_test_util.h

index f70af01ff3e21eb66273a160d6304871e9bfe9b9..c01cf64b045c6db17609e8661dab365e2ebdaf8f 100644

--- a/extensions/browser/api/cast_channel/cast_test_util.h

+++ b/extensions/browser/api/cast_channel/cast_test_util.h

@@ -92,9 +92,12 @@ class MockCastSocket : public CastSocket {

MockCastTransport* mock_transport() const { return mock_transport_.get(); }

+ const std::string& owner_extension_id() const override;

private:

std::unique_ptr<MockCastTransport> mock_transport_;

std::unique_ptr<CastTransport::Delegate> delegate_;

+ std::string owner_extension_id_;

DISALLOW_COPY_AND_ASSIGN(MockCastSocket);

};