Views/Harmony Remove references to ui/views/layout/layout_constants.h

Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
Review-Url: https://codereview.chromium.org/2891013002
Cr-Commit-Position: refs/heads/master@{#472889}
Committed: https://chromium.googlesource.com/chromium/src/+/a8946999597874d4773c3bc74a3d20ec8b63410b

[ananta, 2017-05-18 03:16:28]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-05-18 03:16:29]

https://codereview.chromium.org/2891013002/diff/1/chrome/browser/ui/views/set...
File chrome/browser/ui/views/settings_reset_prompt_dialog.cc (right):

https://codereview.chromium.org/2891013002/diff/1/chrome/browser/ui/views/set...
chrome/browser/ui/views/settings_reset_prompt_dialog.cc:45:
DISTANCE_DIALOG_BUTTON_MARGIN),
Wasn't sure about a simpler FillLayout here.

[ananta, 2017-05-18 03:16:42]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:18:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:31:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ananta, 2017-05-18 04:36:09]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 04:37:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-05-18 06:10:26]

LGTM

https://codereview.chromium.org/2891013002/diff/1/chrome/browser/ui/views/set...
File chrome/browser/ui/views/settings_reset_prompt_dialog.cc (right):

https://codereview.chromium.org/2891013002/diff/1/chrome/browser/ui/views/set...
chrome/browser/ui/views/settings_reset_prompt_dialog.cc:45:
DISTANCE_DIALOG_BUTTON_MARGIN),
On 2017/05/18 03:16:29, ananta wrote:
> Wasn't sure about a simpler FillLayout here.

Yeah, you could probably switch to a FillLayout if you set these insets on the
host (they can't be set on FillLayout itself).

[commit-bot: I haz the power, 2017-05-18 07:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 07:12:33]

Dry run: This issue passed the CQ dry run.

[ananta, 2017-05-18 18:46:10]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:47:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495133170891110,
"parent_rev": "78cd664ac3acc2860377064d0541b015486749d1", "commit_rev":
"a8946999597874d4773c3bc74a3d20ec8b63410b"}

[commit-bot: I haz the power, 2017-05-18 18:53:35]

Description was changed from

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2891013002
Cr-Commit-Position: refs/heads/master@{#472889}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8946999597874d4773c3bc74a3d...
==========

[commit-bot: I haz the power, 2017-05-18 18:53:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8946999597874d4773c3bc74a3d...