Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2890983003: Remove AshPanelContents (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
Reviewers:
benwells, oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, sadrul, kalyank, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AshPanelContents Changes: This is a follow up CL of crrev.com/2886293002. ash_panel_contents and launcher_favicon_loader is removed in this CL. BUG=691099 TEST=covered by tests Review-Url: https://codereview.chromium.org/2890983003 Cr-Commit-Position: refs/heads/master@{#472870} Committed: https://chromium.googlesource.com/chromium/src/+/e389a8213ee8167d6de0cfd55ad9c4a9ce9b7b14

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -582 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/ash/launcher/launcher_favicon_loader.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 chunk +0 lines, -189 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Qiang(Joe) Xu
In crrev.com/2886293002, ash_panel_contents include is removed. The related classes/files are removed in this CL. PTAL. ...
3 years, 7 months ago (2017-05-18 05:26:49 UTC) #6
oshima
lgtm
3 years, 7 months ago (2017-05-18 06:15:07 UTC) #11
benwells
lgtm nice!
3 years, 7 months ago (2017-05-18 06:50:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890983003/40001
3 years, 7 months ago (2017-05-18 17:46:22 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:53:30 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e389a8213ee8167d6de0cfd55ad9...

Powered by Google App Engine
This is Rietveld 408576698