Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2890983002: [ObjC ARC] Converts components/signin/ios/browser:test_support to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by liaoyuke
Modified:
1 month ago
Reviewers:
bzanotti
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/signin/ios/browser:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2890983002 Cr-Commit-Position: refs/heads/master@{#473602} Committed: https://chromium.googlesource.com/chromium/src/+/e2705e6425ef090370a6bcd167045e56a22c3d3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M components/signin/ios/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm View 2 chunks +7 lines, -3 lines 0 comments Download
Trybot results:  win_chromium_rel_ng   win_chromium_x64_rel_ng   win_clang   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-device   ios-simulator   ios-device-xcode-clang   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   android_n5x_swarming_rel   cast_shell_android   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_rel_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   ios-device-xcode-clang   ios-simulator   linux_chromium_tsan_rel_ng   ios-device   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_n5x_swarming_rel   android_compile_dbg   android_cronet   android_arm64_dbg_recipe   android_clang_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
liaoyuke
Hi Bzanotti, PTAL. Thank you very much!
1 month ago (2017-05-18 15:51:09 UTC) #6
bzanotti
lgtm
1 month ago (2017-05-22 14:54:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890983002/1
1 month ago (2017-05-22 15:40:16 UTC) #9
commit-bot: I haz the power
1 month ago (2017-05-22 17:00:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2705e6425ef090370a6bcd16704...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318