third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp - Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp ('k') | third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp b/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp

index 2a164b568c08949c8c51da1c15960a9b900ec9bf..50a5c61948fec858d6d767d2deb2703c7c77c6cc 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp

@@ -15,7 +15,7 @@ uint64_t IdFromCompositorElementId(CompositorElementId element_id) {

}

TEST_F(CompositorElementIdTest, EncodeDecode) {

- CompositorElementId element_id = CompositorElementIdFromDOMNodeId(

+ CompositorElementId element_id = CompositorElementIdFromPaintLayerId(

1, CompositorElementIdNamespace::kPrimary);

EXPECT_EQ(1u, IdFromCompositorElementId(element_id));

EXPECT_EQ(CompositorElementIdNamespace::kPrimary,

@@ -27,10 +27,10 @@ TEST_F(CompositorElementIdTest, EncodeDecode) {

EXPECT_EQ(CompositorElementIdNamespace::kLinkHighlight,

NamespaceFromCompositorElementId(element_id));

- element_id = CompositorElementIdFromDOMNodeId(

- 23, CompositorElementIdNamespace::kScroll);

+ element_id = CompositorElementIdFromScrollbarId(

+ 23, CompositorElementIdNamespace::kScrollbar);

EXPECT_EQ(23u, IdFromCompositorElementId(element_id));

- EXPECT_EQ(CompositorElementIdNamespace::kScroll,

+ EXPECT_EQ(CompositorElementIdNamespace::kScrollbar,

NamespaceFromCompositorElementId(element_id));

}