Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp b/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp
index 95a7bfffaf4c622b5e3282c7ed3ff31942dbb3f3..1ce057112434cb7f7ef5d6a2b97cac60057c7a34 100644
--- a/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp
+++ b/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp
@@ -4,6 +4,8 @@
#include "platform/graphics/CompositorElementId.h"
+#include "platform/RuntimeEnabledFeatures.h"
+
namespace blink {
static CompositorElementId CreateCompositorElementId(
@@ -22,14 +24,30 @@ static CompositorElementId CreateCompositorElementId(
}
CompositorElementId PLATFORM_EXPORT
+CompositorElementIdFromPaintLayerId(PaintLayerId id,
+ CompositorElementIdNamespace namespace_id) {
+ DCHECK(namespace_id == CompositorElementIdNamespace::kPrimary ||
+ namespace_id == CompositorElementIdNamespace::kScroll);
+ return CreateCompositorElementId(id, namespace_id);
+}
+
+CompositorElementId PLATFORM_EXPORT
CompositorElementIdFromDOMNodeId(DOMNodeId id,
CompositorElementIdNamespace namespace_id) {
+ DCHECK(namespace_id == CompositorElementIdNamespace::kViewport ||
+ namespace_id == CompositorElementIdNamespace::kLinkHighlight ||
+ namespace_id == CompositorElementIdNamespace::kRootScroll ||
+ namespace_id == CompositorElementIdNamespace::kScrollState ||
+ namespace_id ==
+ CompositorElementIdNamespace::kPrimaryCompositorProxy ||
+ namespace_id == CompositorElementIdNamespace::kScrollCompositorProxy);
return CreateCompositorElementId(id, namespace_id);
}
CompositorElementId PLATFORM_EXPORT
CompositorElementIdFromScrollbarId(ScrollbarId id,
CompositorElementIdNamespace namespace_id) {
+ DCHECK(namespace_id == CompositorElementIdNamespace::kScrollbar);
return CreateCompositorElementId(id, namespace_id);
}

Powered by Google App Engine
This is Rietveld 408576698