Cache the brand code to avoid hundreds of repeated reads.

Cache the brand code to avoid hundreds of repeated reads.

BUG=723072
Review-Url: https://codereview.chromium.org/2890943005
Cr-Commit-Position: refs/heads/master@{#473102}
Committed: https://chromium.googlesource.com/chromium/src/+/04749717bf2f41bf945b73d9729d24eb262b2843

[Boris Vidolov, 2017-05-19 01:33:14]

Description was changed from

==========
Cache the brand code to avoid hundreds of repeated reads.

BUG=723072
==========

to

==========
Cache the brand code to avoid hundreds of repeated reads.

BUG=723072
==========

[Boris Vidolov, 2017-05-19 01:33:15]

borisv@chromium.org changed reviewers:
+ pkasting@chromium.org

[Boris Vidolov, 2017-05-19 01:37:28]

Peter, PTAL. My previous CL got reverted as it broke non-Windows official
builds.

Changes:
1. "auto" ->"auto*" to please clank.
2. added braces around if the new 'if' block.

[Peter Kasting, 2017-05-19 01:48:45]

LGTM

https://codereview.chromium.org/2890943005/diff/1/chrome/browser/search_engin...
File chrome/browser/search_engines/ui_thread_search_terms_data.cc (right):

https://codereview.chromium.org/2890943005/diff/1/chrome/browser/search_engin...
chrome/browser/search_engines/ui_thread_search_terms_data.cc:81: if
(!google_brand::GetBrand(extracted)) {
Why {} here?  It's allowed by the style guide, but atypical for Chromium code
when neither condition or body are multi-line.

[borisv, 2017-05-19 02:45:24]

On 2017/05/19 01:48:45, Peter Kasting wrote:
> LGTM
> 
>
https://codereview.chromium.org/2890943005/diff/1/chrome/browser/search_engin...
> File chrome/browser/search_engines/ui_thread_search_terms_data.cc (right):
> 
>
https://codereview.chromium.org/2890943005/diff/1/chrome/browser/search_engin...
> chrome/browser/search_engines/ui_thread_search_terms_data.cc:81: if
> (!google_brand::GetBrand(extracted)) {
> Why {} here?  It's allowed by the style guide, but atypical for Chromium code
> when neither condition or body are multi-line.

Thanks, Peter. In Keystone we enforce curly braces on multi-line ifs - sorry
about that. I removed the braces in the latest patch.

[borisv, 2017-05-19 02:46:20]

The CQ bit was checked by borisv@google.com

[borisv, 2017-05-19 02:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2890943005/#ps20001
(title: "Removed the curly braces to be more consistent with Chromium code.")

[commit-bot: I haz the power, 2017-05-19 02:47:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 04:55:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 04:55:23]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Boris Vidolov, 2017-05-19 05:16:04]

The CQ bit was checked by borisv@chromium.org

[commit-bot: I haz the power, 2017-05-19 05:16:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 05:56:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495170964284140,
"parent_rev": "79ddf599f272c9cbefb767c35f853276182cdb27", "commit_rev":
"04749717bf2f41bf945b73d9729d24eb262b2843"}

[commit-bot: I haz the power, 2017-05-19 05:56:36]

Description was changed from

==========
Cache the brand code to avoid hundreds of repeated reads.

BUG=723072
==========

to

==========
Cache the brand code to avoid hundreds of repeated reads.

BUG=723072

Review-Url: https://codereview.chromium.org/2890943005
Cr-Commit-Position: refs/heads/master@{#473102}
Committed:
https://chromium.googlesource.com/chromium/src/+/04749717bf2f41bf945b73d9729d...
==========

[commit-bot: I haz the power, 2017-05-19 05:56:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04749717bf2f41bf945b73d9729d...