Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2890773002: When creating sockets for ioctl() use AF_INET6 or AF_INET (Closed)

Created:
3 years, 7 months ago by pauljensen
Modified:
3 years, 7 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

When creating sockets for ioctl() use AF_INET6 or AF_INET This fixes issues on IPv6-only linux computers. BUG=694860 Review-Url: https://codereview.chromium.org/2890773002 Cr-Commit-Position: refs/heads/master@{#472556} Committed: https://chromium.googlesource.com/chromium/src/+/7a0c9f84298fa7cf439feeebb32b94d3309cd87c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M net/base/address_tracker_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_interfaces_linux.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/base/network_interfaces_linux.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
pauljensen
Josh, our newest net/ owner (yay!), wanna take a look at this little change?
3 years, 7 months ago (2017-05-17 13:56:00 UTC) #2
jkarlin
lgtm!
3 years, 7 months ago (2017-05-17 14:13:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890773002/1
3 years, 7 months ago (2017-05-17 14:22:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457425)
3 years, 7 months ago (2017-05-17 15:54:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890773002/1
3 years, 7 months ago (2017-05-17 16:03:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457594)
3 years, 7 months ago (2017-05-17 18:09:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890773002/1
3 years, 7 months ago (2017-05-17 18:26:40 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 20:52:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a0c9f84298fa7cf439feeebb32b...

Powered by Google App Engine
This is Rietveld 408576698