Un-skipped wpt/content-security-policy/base-uri

Un-skipped  wpt/content-security-policy/base-uri

Fixed existing test
Moved over and adapted to testharness the local base-uri tests

BUG=694525
Review-Url: https://codereview.chromium.org/2890763002
Cr-Commit-Position: refs/heads/master@{#473152}
Committed: https://chromium.googlesource.com/chromium/src/+/5b593eae748eb6b7145dfbe0692a2b97536c1da9

[andypaicu, 2017-05-17 09:49:48]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[andypaicu, 2017-05-17 09:50:07]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[commit-bot: I haz the power, 2017-05-17 09:50:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 10:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 10:42:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2017-05-17 12:34:43]

LGTM, thanks!

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri-deny.sub.html
(right):

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri-deny.sub.html:19:
assert_not_equals(document.baseURI,
"{{location[scheme]}}://{{domains[www2]}}:{{ports[http][0]}}/");
Can you instead assert that the baseURI is the current URL?

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri_iframe_sandbox.sub.html
(left):

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri_iframe_sandbox.sub.html:10:
<!-- CSP served: base-uri 'self' -->
Did `'self'` not work?

[andypaicu, 2017-05-17 13:33:56]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[andypaicu, 2017-05-17 13:34:13]

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri-deny.sub.html
(right):

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri-deny.sub.html:19:
assert_not_equals(document.baseURI,
"{{location[scheme]}}://{{domains[www2]}}:{{ports[http][0]}}/");
On 2017/05/17 at 12:34:43, Mike West wrote:
> Can you instead assert that the baseURI is the current URL?

Done

[commit-bot: I haz the power, 2017-05-17 13:34:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-05-17 13:36:51]

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri_iframe_sandbox.sub.html
(left):

https://codereview.chromium.org/2890763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/base-uri/base-uri_iframe_sandbox.sub.html:10:
<!-- CSP served: base-uri 'self' -->
On 2017/05/17 at 12:34:43, Mike West wrote:
> Did `'self'` not work?

It did not, it did not seem to match.

[commit-bot: I haz the power, 2017-05-17 14:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 14:42:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[andypaicu, 2017-05-19 09:39:37]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-05-19 09:39:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2890763002/#ps20001
(title: "CR changes")

[commit-bot: I haz the power, 2017-05-19 09:40:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 10:47:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495186777136080,
"parent_rev": "5db23fe6d7151affeaf8b84ac2b16cf1603c456d", "commit_rev":
"5b593eae748eb6b7145dfbe0692a2b97536c1da9"}

[commit-bot: I haz the power, 2017-05-19 10:47:56]

Description was changed from

==========
Un-skipped  wpt/content-security-policy/base-uri

Fixed existing test
Moved over and adapted to testharness the local base-uri tests

BUG=694525
==========

to

==========
Un-skipped  wpt/content-security-policy/base-uri

Fixed existing test
Moved over and adapted to testharness the local base-uri tests

BUG=694525

Review-Url: https://codereview.chromium.org/2890763002
Cr-Commit-Position: refs/heads/master@{#473152}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b593eae748eb6b7145dfbe0692a...
==========

[commit-bot: I haz the power, 2017-05-19 10:48:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b593eae748eb6b7145dfbe0692a...