Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2890723003: Slider events with valuetext (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by aleventhal
Modified:
2 months, 3 weeks ago
Reviewers:
dmazzoni, aleventhal1
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Slider events value change tests and fix BUG=722513 Review-Url: https://codereview.chromium.org/2890723003 Cr-Commit-Position: refs/heads/master@{#473807} Committed: https://chromium.googlesource.com/chromium/src/+/d4019643c7a00fb27ab4b971040140d7826eb1ef

Patch Set 1 #

Patch Set 2 : Add the test #

Patch Set 3 : Update mac tests ... doesn't need to fire value with valuechange event, works with VoiceOver #

Patch Set 4 : Attempt to fix #

Patch Set 5 : fix compilation errors #

Patch Set 6 : Fix compilation error #

Patch Set 7 : Fix compilation error #

Patch Set 8 : Rebase #

Patch Set 9 : Fix compilation error #

Patch Set 10 : try this #

Patch Set 11 : Try again #

Patch Set 12 : Revert accidental change #

Patch Set 13 : Revert more accidental changes #

Total comments: 3

Patch Set 14 : Address review comments #

Patch Set 15 : Only focusable separators have a value #

Patch Set 16 : Mo fixes #

Patch Set 17 : Fix tests #

Patch Set 18 : Compile #

Patch Set 19 : Compile #

Patch Set 20 : Fix tests #

Patch Set 21 : Return IsRange() of true for moveable separator (splitter) #

Patch Set 22 : Add valuemin/max to separator test #

Patch Set 23 : Expand role check for value exposure in blink_ax_tree_source.cc so that a focusable separator expos… #

Patch Set 24 : Fix tests #

Patch Set 25 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -77 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +34 lines, -34 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 7 chunks +38 lines, -25 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-orientation-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-scrollbar-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-separator.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-separator-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-separator-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-separator-expected-win.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-both-change.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-both-change-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-both-change-expected-win.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-change.html View 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-change-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-value-change-expected-win.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-valuetext-change.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-valuetext-change-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-slider-valuetext-change-expected-win.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/html/meter-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 112 (102 generated)
aleventhal
Ready for review
3 months ago (2017-05-19 18:07:22 UTC) #47
dmazzoni
lgtm https://codereview.chromium.org/2890723003/diff/230001/content/browser/accessibility/browser_accessibility_com_win.cc File content/browser/accessibility/browser_accessibility_com_win.cc (right): https://codereview.chromium.org/2890723003/diff/230001/content/browser/accessibility/browser_accessibility_com_win.cc#newcode769 content/browser/accessibility/browser_accessibility_com_win.cc:769: bool BrowserAccessibilityComWin::IsRangeValueSupported(int32_t role) { Maybe name this ia_role ...
3 months ago (2017-05-19 19:03:00 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723003/250001
3 months ago (2017-05-19 19:34:58 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723003/250001
3 months ago (2017-05-19 19:38:36 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723003/270001
3 months ago (2017-05-19 19:47:16 UTC) #57
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/415918)
3 months ago (2017-05-19 20:28:30 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723003/290001
3 months ago (2017-05-19 22:26:21 UTC) #62
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/458753) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 months ago (2017-05-19 22:56:40 UTC) #64
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723003/470001
2 months, 3 weeks ago (2017-05-23 04:09:29 UTC) #109
commit-bot: I haz the power
2 months, 3 weeks ago (2017-05-23 04:15:35 UTC) #112
Message was sent while issue was closed.
Committed patchset #25 (id:470001) as
https://chromium.googlesource.com/chromium/src/+/d4019643c7a00fb27ab4b9710401...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b