Fix a bug in updating physical backing size

Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is empty and not used. When adding a 
child, Empty physical size should not be propagated down since it
can overwrite valid size in the children. It handles WindowAndroid
case as well, in more general fashion.

This changes fixes the test that became flaky by 
https://crrev.com/2842693005.

BUG=721906
Review-Url: https://codereview.chromium.org/2890713002
Cr-Commit-Position: refs/heads/master@{#472694}
Committed: https://chromium.googlesource.com/chromium/src/+/3577357065de1e5a173163335406faa28932c07c

[Jinsuk Kim, 2017-05-17 03:20:30]

Description was changed from

==========
Fix the bug updating physical backing size

|physical_size_| in all ViewAndroid objects (for wcva/rwhva) should have
been updated before wcva/rwhva use it. This CL rectifies the error
which could happen when rwhva::GetPhysicalBackingSize() gets called
while physical sizes are being updated.

BUG=721906
==========

to

==========
Fix a bug in updating physical backing size

|physical_size_| in all ViewAndroid objects (for wcva/rwhva) should have
been updated before wcva/rwhva use it. This CL rectifies the error
which could happen when rwhva::GetPhysicalBackingSize() gets called
while physical sizes are being updated.

BUG=721906
==========

[Jinsuk Kim, 2017-05-17 06:16:50]

Patchset #2 (id:20001) has been deleted

[Jinsuk Kim, 2017-05-17 06:16:58]

Patchset #1 (id:1) has been deleted

[Jinsuk Kim, 2017-05-17 06:19:59]

Description was changed from

==========
Fix a bug in updating physical backing size

|physical_size_| in all ViewAndroid objects (for wcva/rwhva) should have
been updated before wcva/rwhva use it. This CL rectifies the error
which could happen when rwhva::GetPhysicalBackingSize() gets called
while physical sizes are being updated.

BUG=721906
==========

to

==========
Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is not used. When adding a child,
physical size in WindowAndroid should not be propagated down
as it can override valid sizes in the child. This changes fixes
the test that became flaky by https://crrev.com/2842693005.

BUG=721906
==========

[Jinsuk Kim, 2017-05-17 10:11:23]

jinsukkim@chromium.org changed reviewers:
+ boliu@chromium.org, nyquist@chromium.org

[Jinsuk Kim, 2017-05-17 10:11:23]

nyquist@ Please review changes in chrome/
boliu@ Please review changes in ui/

[boliu, 2017-05-17 16:21:13]

https://codereview.chromium.org/2890713002/diff/40001/ui/android/view_android.cc
File ui/android/view_android.cc (right):

https://codereview.chromium.org/2890713002/diff/40001/ui/android/view_android...
ui/android/view_android.cc:131: if (this != GetWindowAndroid())
maybe more generally, don't propagate empty sizes?, or keep track of a bool
whether size is set explicitly?

[Jinsuk Kim, 2017-05-18 01:53:11]

Description was changed from

==========
Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is not used. When adding a child,
physical size in WindowAndroid should not be propagated down
as it can override valid sizes in the child. This changes fixes
the test that became flaky by https://crrev.com/2842693005.

BUG=721906
==========

to

==========
Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is empty and not used. When adding a 
child, Empty physical size should not be propagated down since it
can overwrite valid size in the children. It handles WindowAndroid
case as well, in more general fashion.

This changes fixes the test that became flaky by 
https://crrev.com/2842693005.

BUG=721906
==========

[Jinsuk Kim, 2017-05-18 01:54:39]

https://codereview.chromium.org/2890713002/diff/40001/ui/android/view_android.cc
File ui/android/view_android.cc (right):

https://codereview.chromium.org/2890713002/diff/40001/ui/android/view_android...
ui/android/view_android.cc:131: if (this != GetWindowAndroid())
On 2017/05/17 16:21:12, boliu wrote:
> maybe more generally, don't propagate empty sizes?, or keep track of a bool
> whether size is set explicitly?

Changed to checking empty size.

[boliu, 2017-05-18 04:38:07]

lgtm

[Jinsuk Kim, 2017-05-18 04:43:44]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:45:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:59:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nyquist, 2017-05-18 05:38:24]

chrome lgtm

[Jinsuk Kim, 2017-05-18 05:51:21]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-05-18 05:52:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495086681383700,
"parent_rev": "144c0c992f9c21d0c6c4568f262bae25eed0ed1d", "commit_rev":
"3577357065de1e5a173163335406faa28932c07c"}

[commit-bot: I haz the power, 2017-05-18 05:58:49]

Description was changed from

==========
Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is empty and not used. When adding a 
child, Empty physical size should not be propagated down since it
can overwrite valid size in the children. It handles WindowAndroid
case as well, in more general fashion.

This changes fixes the test that became flaky by 
https://crrev.com/2842693005.

BUG=721906
==========

to

==========
Fix a bug in updating physical backing size

|physical_size_| in ViewAndroid objects are valid from wcva down,
while that in WindowAndroid is empty and not used. When adding a 
child, Empty physical size should not be propagated down since it
can overwrite valid size in the children. It handles WindowAndroid
case as well, in more general fashion.

This changes fixes the test that became flaky by 
https://crrev.com/2842693005.

BUG=721906

Review-Url: https://codereview.chromium.org/2890713002
Cr-Commit-Position: refs/heads/master@{#472694}
Committed:
https://chromium.googlesource.com/chromium/src/+/3577357065de1e5a173163335406...
==========

[commit-bot: I haz the power, 2017-05-18 05:58:50]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3577357065de1e5a173163335406...