Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2890703002: SafeBrowsing: allow WebView to customize the Help Center URL (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index e866451be644bf46324dc2ba87f76d9be972c403..091be51d806f8fb5de624158c6d653f959a4910d 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -76,7 +76,8 @@ class SafeBrowsingBlockingPageFactoryImpl
web_contents->GetBrowserContext()->IsOffTheRecord(),
IsExtendedReportingEnabled(*prefs), IsScout(*prefs),
is_proceed_anyway_disabled,
- BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources));
+ BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources),
+ nullptr);
Jialiu Lin 2017/05/17 15:47:46 nit: some in-line comment will be helpful. e.g.
felt 2017/05/17 15:55:50 I'd prefer to have Chrome pass in the default link
Nate Fischer 2017/05/17 22:34:43 Sure, I went with Felt's suggestion
return new SafeBrowsingBlockingPage(ui_manager, web_contents,
main_frame_url, unsafe_resources,

Powered by Google App Engine
This is Rietveld 408576698