Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2890683002: Override RTT and throughput when ECT is overridden (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by tbansal1
Modified:
1 month, 1 week ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Override RTT and throughput when ECT is overridden When Effective Connection Type (ECT) is overridden, then HTTP RTT, transport RTT and throughput are also overridden. BUG=717278 Review-Url: https://codereview.chromium.org/2890683002 Cr-Commit-Position: refs/heads/master@{#472773} Committed: https://chromium.googlesource.com/chromium/src/+/15fb9f6cd7ef8820ca37a1da0e38b66975ace717

Patch Set 1 : ps #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M net/nqe/network_quality_estimator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 1 chunk +15 lines, -1 line 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 3 chunks +30 lines, -10 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 27 (23 generated)
tbansal1
ryansturm: ptal. Thanks.
1 month, 1 week ago (2017-05-16 23:02:26 UTC) #5
RyanSturm
lgtm
1 month, 1 week ago (2017-05-16 23:47:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890683002/40001
1 month, 1 week ago (2017-05-18 12:00:24 UTC) #24
commit-bot: I haz the power
1 month, 1 week ago (2017-05-18 12:06:13 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15fb9f6cd7ef8820ca37a1da0e38...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589