Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2890663002: Remove update-webgl-conformance-tests. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, Ken Russell (switch to Gerrit), Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove update-webgl-conformance-tests. The code related to update-webgl-conformance-tests hasn't been touched in a long time, so I suspect it's unused. BUG=677561 Review-Url: https://codereview.chromium.org/2890663002 Cr-Commit-Position: refs/heads/master@{#472273} Committed: https://chromium.googlesource.com/chromium/src/+/830d4857d4d2b1acc258c6f58cf1c2c918b3d89c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -289 lines) Patch
D third_party/WebKit/Tools/Scripts/update-webgl-conformance-tests View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/webgl/__init__.py View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/webgl/update_webgl_conformance_tests.py View 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/webgl/update_webgl_conformance_tests_unittest.py View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
I'm pretty sure that this script is unused (it was added 7 years ago and ...
3 years, 7 months ago (2017-05-16 22:06:33 UTC) #3
jeffcarp
lgtm
3 years, 7 months ago (2017-05-16 22:11:03 UTC) #6
Ken Russell (switch to Gerrit)
LGTM. Since this script was added we've completely changed how these tests are run in ...
3 years, 7 months ago (2017-05-16 23:11:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890663002/1
3 years, 7 months ago (2017-05-16 23:15:48 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:57:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/830d4857d4d2b1acc258c6f58cf1...

Powered by Google App Engine
This is Rietveld 408576698