Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2890643002: Fix a typo in the header filename in BUILD.gn (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in the header filename in media/base/BUILD.gn The typo was introduced in https://codereview.chromium.org/2856253004. BUG=661774, 716359 Review-Url: https://codereview.chromium.org/2890643002 Cr-Commit-Position: refs/heads/master@{#472358} Committed: https://chromium.googlesource.com/chromium/src/+/90e87f4bb986def04af8f8310cd495bfbead49bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-16 21:24:22 UTC) #4
liberato (no reviews please)
lgtm, thanks! -fl
3 years, 7 months ago (2017-05-16 21:32:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890643002/1
3 years, 7 months ago (2017-05-16 21:49:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/455308)
3 years, 7 months ago (2017-05-16 23:30:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890643002/1
3 years, 7 months ago (2017-05-17 05:12:34 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 06:50:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90e87f4bb986def04af8f8310cd4...

Powered by Google App Engine
This is Rietveld 408576698