Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2890623002:
Revert of Disable blink_perf.bindings benchmark on Android Svelte (Closed)
DescriptionRevert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ )
Reason for revert:
Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug).
Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it.
Original issue's description:
> Disable blink_perf.bindings benchmark on Android Svelte
>
> The benchmark is failing on downstream Android Svelte bots.
>
> NOTRY=true
> TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org
> BUG=563979
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575
> Cr-Commit-Position: refs/heads/master@{#362404}
BUG=563979
Review-Url: https://codereview.chromium.org/2890623002
Cr-Commit-Position: refs/heads/master@{#472305}
Committed: https://chromium.googlesource.com/chromium/src/+/2ec70963f4e92f375b9387f2bac2ae1be750a013
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 22 (11 generated)
Created Revert of Disable blink_perf.bindings benchmark on Android Svelte
Description was changed from ========== Revert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ ) Reason for revert: Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug). Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it. Original issue's description: > Disable blink_perf.bindings benchmark on Android Svelte > > The benchmark is failing on downstream Android Svelte bots. > > NOTRY=true > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org > BUG=563979 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 > Cr-Commit-Position: refs/heads/master@{#362404} TBR=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org,skyostil@... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=563979 ========== to ========== Revert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ ) Reason for revert: Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug). Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it. Original issue's description: > Disable blink_perf.bindings benchmark on Android Svelte > > The benchmark is failing on downstream Android Svelte bots. > > NOTRY=true > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org > BUG=563979 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 > Cr-Commit-Position: refs/heads/master@{#362404} BUG=563979 ==========
lgtm
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jbroman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2890623002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494977561307220,
"parent_rev": "a2adba27e3ef69283f5060c04c4e64b02bb6ea4d", "commit_rev":
"2ec70963f4e92f375b9387f2bac2ae1be750a013"}
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ ) Reason for revert: Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug). Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it. Original issue's description: > Disable blink_perf.bindings benchmark on Android Svelte > > The benchmark is failing on downstream Android Svelte bots. > > NOTRY=true > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org > BUG=563979 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 > Cr-Commit-Position: refs/heads/master@{#362404} BUG=563979 ========== to ========== Revert of Disable blink_perf.bindings benchmark on Android Svelte (patchset #1 id:1 of https://codereview.chromium.org/1489013002/ ) Reason for revert: Hoping that this is no longer broken; most of the data that would be helpful in debugging is gone to the sands of time (see bug). Perf sheriffs: if blink_perf.bindings starts failing on Svelte, this CL is the culprit and you should revert it. Original issue's description: > Disable blink_perf.bindings benchmark on Android Svelte > > The benchmark is failing on downstream Android Svelte bots. > > NOTRY=true > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org > BUG=563979 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/27963a3f1cb0adb9948adf48bf9231ad334b5575 > Cr-Commit-Position: refs/heads/master@{#362404} BUG=563979 Review-Url: https://codereview.chromium.org/2890623002 Cr-Commit-Position: refs/heads/master@{#472305} Committed: https://chromium.googlesource.com/chromium/src/+/2ec70963f4e92f375b9387f2bac2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2ec70963f4e92f375b9387f2bac2...
Message was sent while issue was closed.
yukishiino@chromium.org changed reviewers: + yukishiino@chromium.org
Message was sent while issue was closed.
LGTM. Thanks for taking care of this. |
