Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2890603007: [heap] Remove max_executable_size resource constraint. (Closed)

Created:
3 years, 7 months ago by Hannes Payer (out of office)
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove max_executable_size resource constraint. BUG=chromium:716032 Review-Url: https://codereview.chromium.org/2890603007 Cr-Commit-Position: refs/heads/master@{#45400} Committed: https://chromium.googlesource.com/v8/v8/+/a9e56f4f36d70d16a956367133dda258c4f52bf4

Patch Set 1 #

Patch Set 2 : remove constants #

Patch Set 3 : deprecate #

Total comments: 4

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M include/v8.h View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M src/api.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
ulan
lgtm https://codereview.chromium.org/2890603007/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2890603007/diff/40001/include/v8.h#newcode5908 include/v8.h:5908: V8_DEPRECATE_SOON("max_executable_size_ is subsumed max_old_space_size_", subsumed _by_ https://codereview.chromium.org/2890603007/diff/40001/include/v8.h#newcode5912 include/v8.h:5912: ...
3 years, 7 months ago (2017-05-18 14:30:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890603007/60001
3 years, 7 months ago (2017-05-18 16:57:12 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/a9e56f4f36d70d16a956367133dda258c4f52bf4
3 years, 7 months ago (2017-05-18 17:38:07 UTC) #16
Hannes Payer (out of office)
3 years, 7 months ago (2017-05-19 09:46:19 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2890603007/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2890603007/diff/40001/include/v8.h#newcode5908
include/v8.h:5908: V8_DEPRECATE_SOON("max_executable_size_ is subsumed
max_old_space_size_",
On 2017/05/18 14:30:47, ulan wrote:
> subsumed _by_

Done.

https://codereview.chromium.org/2890603007/diff/40001/include/v8.h#newcode5912
include/v8.h:5912: V8_DEPRECATE_SOON("max_executable_size_ is subsumed
max_old_space_size_",
On 2017/05/18 14:30:47, ulan wrote:
> ditto

Done.

Powered by Google App Engine
This is Rietveld 408576698